Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getInputProps #734

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lifeiscontent
Copy link
Contributor

@lifeiscontent lifeiscontent commented Aug 9, 2024

@edmundhung I'm not sure if this is the right fix, but I noticed in some playwright tests the file input will have an array of undefined values and [undefined,undefined] results in "," when toString() is called

Copy link

changeset-bot bot commented Aug 9, 2024

⚠️ No Changeset found

Latest commit: 24baf23

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@edmundhung
Copy link
Owner

edmundhung commented Aug 10, 2024

the file input will have an array of undefined values and [undefined,undefined]

I guess this happens only with a multiple file input on full document reload in which we have to strip the files from the server as it is not serializable.

But I am not sure how it ends up with the value you see there because the initialValue would still be array so it shouldn't set anything to the default value. Do I missed something?

@lifeiscontent
Copy link
Contributor Author

Do I missed something?

Yeah, I forget which test I came across that was showing it, but if you throw an error in the getInputProps by checking if its an array you'll find it if you run playwright tests

Otherwise, I can follow up when I find it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants