feat: suppress passthrough message when filter exists but flags excluded it#36
Merged
edouard-claude merged 1 commit intoedouard-claude:masterfrom Apr 16, 2026
Conversation
…ded it Previously, running a command like `go test -v` would print "snip: no filter for 'go'" even though a go-test filter exists. The message was misleading because the filter was simply bypassed due to an exclude_flag (-v), not missing entirely. Now the message is only shown when no filter is registered at all for that command. Commands excluded by flags pass through silently. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
edouard-claude
approved these changes
Apr 16, 2026
Owner
edouard-claude
left a comment
There was a problem hiding this comment.
LGTM. Fix ciblé et bien motivé, conforme aux conventions du projet.
Suggestions non bloquantes pour une future itération :
- Ajouter un test
HasAnyFilterpour le cas command-only (filtrenpmsans sous-commande doit matcher n'importe quelle sous-commande). - Ajouter un test d'intégration pipeline qui capture stderr pour valider que le message est bien muet quand un filtre est exclu par flags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, running a command like
go test -vwould print "snip: no filter for 'go'" even though a go-test filter exists. The message was misleading because the filter was simply bypassed due to an exclude_flag (-v), not missing entirely.Now the message is only shown when no filter is registered at all for that command. Commands excluded by flags pass through silently.
Example from the snip repo:
Before:
After: