Skip to content

publication info description : punctuation and separators should be localized#962 #1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

publication info description : punctuation and separators should be localized#962 #1847

wants to merge 2 commits into from

Conversation

panaC
Copy link
Member

@panaC panaC commented Oct 24, 2022

fix #962

@panaC panaC requested a review from danielweck October 24, 2022 14:22
@panaC panaC self-assigned this Oct 24, 2022
danielweck
danielweck requested changes Oct 28, 2022
View reviewed changes
Copy link
Member

@danielweck danielweck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR introduces regressions due to labels being used elsewhere with the expectation of not containing punctuation (e.g. no : suffix). I will check all occurrences (a quick code search reveals that catalog.publisher is used in the "data grid" bookshelf.

@danielweck danielweck closed this Nov 27, 2022
@danielweck danielweck deleted the fix962 branch April 25, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielweck danielweck danielweck requested changes

Assignees

@panaC panaC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publication info popup dialog (metadata), punctuation and separators should be localized
2 participants
@panaC @danielweck