Skip to content

Conversation

@DottorPagliaccius
Copy link

…ifications

added a way to specify an optional Intent Filter Action property to avoid starting with MainLauncher Activity
added notification Id parameter to activity Extras

Just recreated PR from https://github.com/edsnider/Xamarin.Plugins/pull/35

…ifications

added a way to specify an optional Intent Filter Action property to avoid starting with MainLauncher Activity
added notification Id parameter to activity Extras
@edsnider
Copy link
Owner

Do you have steps that reproduce the problem that this is solving?

@DottorPagliaccius
Copy link
Author

As said here https://github.com/edsnider/Xamarin.Plugins/issues/28

I run the app, launch scheduled local notification, click on the notification icon: then the app close and recreate self, then crashes.

Tried on various Android device (Lollipop or Marshmallow).

@edsnider
Copy link
Owner

Ok, does this happen in Xamarin.Forms or traditional Xamarin.Android, or both? I can't reproduce the issue with the sample application, but maybe it's too simple of an app.

@DottorPagliaccius
Copy link
Author

DottorPagliaccius commented Mar 18, 2017

I've only tried with Forms.

@mrutter
Copy link

mrutter commented Apr 27, 2017

Hello.

Maybe I have the same issue.
My XF apps crashes every time the user taps on the notification.
This happens on many different devices including XS debugger with different API levels.

Are you planning to merge this pull request?

@mrutter
Copy link

mrutter commented May 16, 2017

@edsnider, @jamesmontemagno
do you plan to merge these requests and deploy an updated Nuget package?

Thank you very much.
-m

@edsnider
Copy link
Owner

I haven't been able to reproduce the bug this PR is attempting to address, can you point me to a repo or some sample code that is seeing the error?

@mrutter
Copy link

mrutter commented May 16, 2017

Hi @edsnider.
Thank you for your answer.
Yes of course, I will update this thread soon with the log of the exception.
I also will try to reproduce the same behavior in a simple app (not easy but I will try).

I will be back soon with some more information.

@GeorgyRezchikov
Copy link

I had the same problem.
I used the code from this commit:
f6c700d
And the behavior after the transition from the notification was expected.

Please update the NuGet package.

@GalaxiaGuy
Copy link

@edsnider I believe the sample in this repo demonstrates the original behavior (not the crash), however I wasn't able to get it to build to confirm. So, here is a repo that contains the sample, but updated to the latest Xamarin Forms and plugin versions, along with LaunchMode = SingleTop on the activity:

https://github.com/GalaxiaGuy/localnotificationssample

When you tap on the notifications triggered by the app, the activity is recreated, instead of the existing activity being reused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants