-
Notifications
You must be signed in to change notification settings - Fork 80
Android: fixed issue where activity was being recreated for local not… #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ifications added a way to specify an optional Intent Filter Action property to avoid starting with MainLauncher Activity added notification Id parameter to activity Extras
|
Do you have steps that reproduce the problem that this is solving? |
|
As said here https://github.com/edsnider/Xamarin.Plugins/issues/28 I run the app, launch scheduled local notification, click on the notification icon: then the app close and recreate self, then crashes. Tried on various Android device (Lollipop or Marshmallow). |
|
Ok, does this happen in Xamarin.Forms or traditional Xamarin.Android, or both? I can't reproduce the issue with the sample application, but maybe it's too simple of an app. |
|
I've only tried with Forms. |
|
Hello. Maybe I have the same issue. Are you planning to merge this pull request? |
|
@edsnider, @jamesmontemagno Thank you very much. |
|
I haven't been able to reproduce the bug this PR is attempting to address, can you point me to a repo or some sample code that is seeing the error? |
|
Hi @edsnider. I will be back soon with some more information. |
|
I had the same problem. Please update the NuGet package. |
|
@edsnider I believe the sample in this repo demonstrates the original behavior (not the crash), however I wasn't able to get it to build to confirm. So, here is a repo that contains the sample, but updated to the latest Xamarin Forms and plugin versions, along with https://github.com/GalaxiaGuy/localnotificationssample When you tap on the notifications triggered by the app, the activity is recreated, instead of the existing activity being reused. |
…ifications
added a way to specify an optional Intent Filter Action property to avoid starting with MainLauncher Activity
added notification Id parameter to activity Extras
Just recreated PR from https://github.com/edsnider/Xamarin.Plugins/pull/35