JU-6: refactor tests to avoid events failure #566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariajgrimaldi
force-pushed
the
li/ednx/JU-6
branch
2 times, most recently
from
405dc0e to
ec206aa
Compare
mariajgrimaldi
changed the title
mariajgrimaldi
requested review from
MaferMazu,
MoisesGSalas,
jignaciopm and
magajh
MoisesGSalas
approved these changes
Nov 2, 2021
mariajgrimaldi
force-pushed
the
li/ednx/JU-6
branch
2 times, most recently
from
dd7f343 to
4abfc60
Compare
…tent profile errors fix failing tests due to current date fix tests
mariajgrimaldi
force-pushed
the
li/ednx/JU-6
branch
from
4abfc60 to
74ee7ac
Compare
Ian2012
pushed a commit
that referenced
this pull request
Oct 3, 2024
reverts changes from #566 Commit generated by workflow `openedx/edx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces
User.objects.create_userreferences withUserProfile.create, to automatically create the user's profile avoiding tests errors.Supporting information
These changes were discussed -here- after we encountered some errors while using the user's profile in some tests. For example, here:
https://build.testeng.edx.org/job/edx-platform-python-pipeline-pr/33620/#showFailuresLink
More in detail:
https://build.testeng.edx.org/job/edx-platform-python-pipeline-pr/33620/testReport/junit/lms.djangoapps.course_goals.tests.test_goals/TestCourseGoalsAPI/Run_Tests___lms_unit___test_add_goal/
Testing instructions
Run edxapp tests:
pytest lms/djangoapps/course_goals/tests/test_goals.py::TestCourseGoalsAPI::test_add_goalpaver test_js_run -s <lms|cms>Other information
This PR improves tests by adding missing data. Won't be needed after maple.