Record 10 accepted bundles contributed as upstream draft PRs#304
Conversation
Adds the frozen PDCA result bundles for ten accepted fixes, each pushed to a draft PR against gramps-project/gramps @ maintenance/gramps61: 3214 -> PR 2444 preformatted-note font-size reset to default 5733 -> PR 2445 ODF drawn-text not scaled with report scale factor 6170 -> PR 2446 sidebar filter Ctrl+C shortcut shadowed 6324 -> PR 2450 cairo/PDF table cell dropped at a page break 6824 -> PR 2452 HTML report media referenced by absolute path 7924 -> PR 2449 child-editor reference lost on parent save 8603 -> PR 2447 family event list shows stale participant 8617 -> PR 2443 bottombar filter gramplet ignored when sidebar hidden 8622 -> PR 2451 citation selector filter hides existing citations 8841 -> PR 2448 note hyperlink click hypersensitive Also updates the committed 7924 interface repro docstring to describe the shared save-door (gramps.gui.savecascade) fix. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 49b450234f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| |---|---|---| | ||
| | C1 — C1 Spec | PASS | The brief states the required complete graph outcome and abort alternative for the Family→Person flow, not just a warning (`brief.md:18`, `brief.md:24`, `brief.md:29`). | | ||
| | C2 — C2 Reproduction (red pre-fix) | PASS | The red condition is re-derived from target source: mother child editor is opened with callback (`gramps/gui/editors/editfamily.py:946`), callback is the only mother-handle write (`gramps/gui/editors/editfamily.py:969`), but save reads/commits mother before close (`gramps/gui/editors/editfamily.py:1294`, `gramps/gui/editors/editfamily.py:1308`, `gramps/gui/editors/editfamily.py:1340`). | | ||
| | C3 — C3 Change | FAIL | The patch routes only `define_ok_button` clicks through the resolver (`patch.diff:15`, `patch.diff:26`), but parent window close still offers SaveDialog with `self.save` directly (`gramps/gui/editors/editprimary.py:247`, `gramps/gui/editors/editprimary.py:255`), missing the brief's OK/save shared path. | |
There was a problem hiding this comment.
For issue 7924, this final bundle's patch.diff now covers the close/Cancel/window-X SaveDialog path by replacing self.save with _save_with_dependent_children (patch.diff around lines 154-164), but the committed review still records the older OK-only implementation as a C3 failure. Since these result bundles are the source record for an accepted upstream PR, this stale verdict (also copied into SUMMARY.md) makes the accepted bundle look Check-failed and directs humans to rework a hole that the final patch already fixed.
Useful? React with 👍 / 👎.
1 participant
Records the frozen PDCA result bundles for ten accepted fixes, each already pushed to a draft PR against
gramps-project/gramps @ maintenance/gramps61.Each bundle is COMPLETE (accepted at sign-off);
patch.diff/commit-msg.txt/pr-description.md/publish.jsonreflect what was pushed. Also updates the committed 7924 interface repro docstring to describe the shared save-door (gramps.gui.savecascade) fix.Scope note: the ten listed bundles only — other untracked bundles and the pre-existing
pdca.toml/issue_8597working-tree changes are intentionally left out. Leftover scratch underresults/issue_6170/.src/(a working copy + embedded checkout) is excluded from the commit.🤖 Generated with Claude Code
Closes #305