Skip to content

Drop timezone settings from Blueprint#27

Merged
edwardtfn merged 4 commits intomainfrom
drop-timezone-support
Feb 27, 2026
Merged

Drop timezone settings from Blueprint#27
edwardtfn merged 4 commits intomainfrom
drop-timezone-support

Conversation

@edwardtfn
Copy link
Copy Markdown
Owner

@edwardtfn edwardtfn commented Feb 27, 2026

Since ESPHome 2025.10.0, the timezone is provided by Home Assistant and can no longer be forced from the ESPHome side, which caused this feature to stop working properly.

Originally, the timezone selection in the Blueprint was introduced as a workaround for issues with ESPHome handling timezones incorrectly. Those issues have now been fixed, and this code is no longer necessary.

With this change, all timezone settings must be managed using the native ESPHome Time component functionality, and any related errors should be addressed in the ESPHome repository.

And to finalize, ESPHome 2026.3.0 will drop support to get_timezone() which will break the previous support anyways.

Summary by CodeRabbit

  • Documentation

    • Removed timezone configuration docs from setup and customization guides
    • Added link to external ESPHome Time component configuration
    • Updated bug report template with version fields, panel model, improved log/YAML fields, and guidance
  • Chores

    • Removed timezone handling and associated panel time initialization flows
    • Added trailing document placeholder line to version manifest and templates

Since ESPHome 2025.10.0, the timezone is provided by Home Assistant and can no longer be forced from the ESPHome side, which caused this feature to stop working properly.

Originally, the timezone selection in the Blueprint was introduced as a workaround for issues with ESPHome handling timezones incorrectly. Those issues have now been fixed, and this code is no longer necessary.

With this change, all timezone settings must be managed using the native ESPHome Time component functionality, and any related errors should be addressed in the ESPHome repository.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 737bb21 and 9e14781.

📒 Files selected for processing (1)
  • .github/workflows/versioning.yml

📝 Walkthrough

Walkthrough

Removed timezone support and documentation: deleted timezone UI fields, global timezone state, timezone-related scripts and boot/stop hooks, timezone processing/logging in panel flows, plus minor bug template and versioning YAML formatting edits.

Changes

Cohort / File(s) Summary
Documentation
docs/blueprint.md, docs/customization.md
Removed timezone sections and historical explanation; added link to ESPHome Time component docs in customization.
ESPhome datetime config
esphome/nspanel_esphome_datetime.yaml
Removed global mui_timezone, timezone scripts (set_timezone, set_timezone_from_globals), boot script extension, stop hooks, and timezone logging/handling.
Blueprint UI / Panel flows
nspanel_easy_blueprint.yaml
Removed Timezone field from Time Format input and all timezone handling from DateTime bootstrap and home page flows.
Issue template & workflows
.github/ISSUE_TEMPLATE/bug.yml, .github/workflows/versioning.yml, versioning/version.yaml
Added Version Information fields and formatting changes to bug template; workflow step to restore YAML end markers; appended trailing ... to version.yaml.

Sequence Diagram(s)

mermaid
sequenceDiagram
participant User as "User (UI)"
participant Panel as "NSPanel Blueprint"
participant Globals as "Global state (mui_timezone)"
participant TimeProv as "Time provider / ESPHome"
Note over User,TimeProv: Old flow (before changes)
User->>Panel: Select timezone / boot
Panel->>Globals: write mui_timezone
Globals->>TimeProv: apply timezone, reconfigure time
TimeProv-->>Panel: time updated

mermaid
sequenceDiagram
participant User as "User (UI)"
participant Panel as "NSPanel Blueprint"
participant TimeProv as "Time provider / ESPHome"
Note over User,TimeProv: New flow (after changes)
User->>Panel: Set time format / boot
Panel->>TimeProv: request time/format (no timezone step)
TimeProv-->>Panel: time updated

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

🐰 I nudged the timezone out of sight,
Hopped through docs and scripts last night,
No globals left to set or chase,
Panels wake with simpler face,
A quiet tick, a calmer pace.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Drop timezone settings from Blueprint' clearly and concisely summarizes the main change: removal of timezone functionality from the Blueprint configuration, matching the primary objective of the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch drop-timezone-support

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@edwardtfn edwardtfn merged commit 9413991 into main Feb 27, 2026
30 checks passed
@edwardtfn edwardtfn deleted the drop-timezone-support branch February 27, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant