Add TFT upload status to version event for smarter notifications#28
Add TFT upload status to version event for smarter notifications#28
Conversation
Fixes #26 When the TFT version doesn't match, the Blueprint shows a generic "Please update TFT" notification. However, if auto-update is enabled (via the Upload TFT add-on), the update will happen automatically after boot — so the message is misleading. This PR enriches the `version` HA event with additional fields so the Blueprint can show context-appropriate messages: | Scenario | Message | |---|---| | Upload TFT add-on **not installed** | "Flash your device including the Upload TFT package" | | Add-on installed, auto-update **disabled** | "Click 'Upload TFT' button" | | Add-on installed, auto-update **enabled** | "Wait around X sec until TFT is updated automatically" |
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR adds documentation for the Upload TFT Add-on, upgrades the NSPanel Easy blueprint version from 1 to 2, introduces conditional telemetry reporting for TFT addon state, and enhances TFT version mismatch handling with awareness of auto-upload configuration and addon installation status. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b4d0c94b4a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/addon_uploat_tft.md`:
- Line 1: The docs file name contains a typo: rename the file
docs/addon_uploat_tft.md to docs/addon_upload_tft.md and update any references
to the old path (e.g., README, mkdocs/nav, other markdown links or import
statements) to point to docs/addon_upload_tft.md so inbound links and
searchability are not broken; search the repo for "addon_uploat_tft.md" and
replace occurrences with "addon_upload_tft.md" and verify links render
correctly.
In `@nspanel_easy_blueprint.yaml`:
- Line 12087: Update the broken documentation link in
nspanel_easy_blueprint.yaml: replace the URL path "docs/addon_upload_tft.md"
with the actual filename "docs/addon_uploat_tft.md" in the markdown link text
shown ("For instructions, please [click
here](https://github.com/edwardtfn/NSPanel-Easy/blob/main/docs/addon_upload_tft.md)").
Fixes #26
When the TFT version doesn't match, the Blueprint shows a generic "Please update TFT" notification. However, if auto-update is enabled (via the Upload TFT add-on), the update will happen automatically after boot — so the message is misleading. This PR enriches the
versionHA event with additional fields so the Blueprint can show context-appropriate messages:Summary by CodeRabbit
Documentation
New Features
Chores