Skip to content

Feat: Allow climate entity as indoor temperature source #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edwardtfn merged 6 commits into from
Apr 1, 2026
Merged

Feat: Allow climate entity as indoor temperature source #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f5d3130
Remove extra blank lines added by release workflow
edwardtfn Mar 31, 2026
b8db110
Do not accept `screensaver` as wake-up page
edwardtfn Mar 31, 2026
4ac6e57
Feat: Allow climate entity as indoor temperature source
edwardtfn Apr 1, 2026
8fb854a
has_value() doesn't validate the current_temperature attribute
edwardtfn Apr 1, 2026
efa839f
Fix fallback temperature unit for climate entity
edwardtfn Apr 1, 2026
94e7294
style: normalize YAML line endings to LF
edwardtfn Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
*.tft binary
*.HMI binary
*.sh text eol=lf
*.yaml text eol=lf
139 changes: 0 additions & 139 deletions .github/ISSUE_TEMPLATE/bug.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,147 +93,9 @@ body:
Please follow the guidelines below to ensure the logs are comprehensive:

- **Boot Issues**: If the problem occurs during boot, capture the logs from the start of your device to a minute or two after the boot completes.





































































Look for errors or unusual messages during this period.

- **TFT File Update Issues**: For problems related to TFT file updates, include logs from the moment you press the **Update TFT Display** button until a few seconds after the device restarts.





































































Pay attention to any error messages or warnings during the update process.

- **Other Issues**: For other types of problems, include logs that encompass the issue's onset and continue for a short duration thereafter. This will help in pinpointing the exact moment and nature of the issue.
Expand All @@ -256,5 +118,4 @@ body:
- **Relevancy is Key**: To expedite troubleshooting, avoid including logs that are not related to the issue at hand. This helps in focusing on the pertinent information.

Your attention to sharing targeted and relevant log data is greatly appreciated and aids in efficient problem resolution.

...
7 changes: 5 additions & 2 deletions esphome/nspanel_esphome_hw_display.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,9 @@ script:
- lambda: |-
disp1->send_command_printf("button_back_font=%i", id(button_back_font));
wakeup_page_id = get_page_id(wakeup_page_name->current_option());
if (wakeup_page_id > 0) disp1->send_command_printf("wakeup_page_id=%" PRIu8, wakeup_page_id);
if (wakeup_page_id != get_page_id("boot") and wakeup_page_id != get_page_id("screensaver"))
disp1->send_command_printf("wakeup_page_id=%" PRIu8, wakeup_page_id);


- id: !extend boot_wrap_up
then:
Expand Down Expand Up @@ -635,7 +637,8 @@ select:
then:
- lambda: |-
wakeup_page_id = get_page_id(x.c_str());
if (wakeup_page_id > 0) disp1->send_command_printf("wakeup_page_id=%" PRIu8, wakeup_page_id);
if (wakeup_page_id != get_page_id("boot") and wakeup_page_id != get_page_id("screensaver"))
disp1->send_command_printf("wakeup_page_id=%" PRIu8, wakeup_page_id);
wait_to_be_ready->execute();
- script.wait: wait_to_be_ready
# Extended by:
Expand Down
2 changes: 1 addition & 1 deletion esphome/nspanel_esphome_version.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ substitutions:
# Value is imported from versioning/version.yaml
<<: !include ../versioning/version.yaml
# Minimum required versions for compatibility
min_blueprint_version: 16
min_blueprint_version: 17
min_tft_version: 15
min_esphome_compiler_version: 2026.1.0
TAG_VERSIONING: nspanel.versioning
Expand Down
38 changes: 33 additions & 5 deletions nspanel_easy_blueprint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ blueprint:

*Only one entity may be selected.*
default: *selector_entity_single_default_empty
selector: &entity_temp_sensor-selector
selector: &entity_temp_sensor_selector
entity:
multiple: *selector_entity_single_multiple
filter:
Expand Down Expand Up @@ -301,9 +301,19 @@ blueprint:

Additionally a temperature correction for the NSPanel sensor is possible under HA Devices.

You may select either a temperature `sensor` entity or a `climate` entity,
in which case the **current temperature** reported by the climate entity will
be used, not its target temperature.

*Only one entity may be selected.*
default: *selector_entity_single_default_empty
selector: *entity_temp_sensor-selector
selector: &entity_temp_or_climate_sensor_selector
entity:
multiple: *selector_entity_single_multiple
filter:
- domain: sensor
device_class: temperature
- domain: climate
home_indoor_temp_icon:
name: Home page - Indoor Temperature Sensor - Icon (Optional)
description: "Icon which should be displayed (Default mdi:thermometer)"
Expand Down Expand Up @@ -4201,7 +4211,7 @@ trigger_variables:
}}

variables:
blueprint_version: 16
blueprint_version: 17
pages:
current: '{{ states(currentpage) }}'
alarm: "alarm"
Expand Down Expand Up @@ -7299,7 +7309,6 @@ actions:
txt: '{{ outdoor_temp_trimmed }}'
continue_on_error: true

##### NSPanel Indoor Temp #####
- &refresh_page_home_indoor_temp
alias: Home page - Indoor temperature
sequence:
Expand All @@ -7325,7 +7334,26 @@ actions:
- '{{ not embedded_indoor_temperature }}'
- '{{ has_value(indoor_temperature_sensor) }}'
- variables:
indoor_temp: '{{ states(indoor_temperature_sensor, rounded=True, with_unit=True) }}'
indoor_temp_raw: >
{%- if indoor_temperature_sensor.split(".")[0] == "climate" -%}
{%- set current_temp = state_attr(indoor_temperature_sensor, "current_temperature") -%}
{{ current_temp | round(1) if is_number(current_temp) else none }}
{%- else -%}
{{ states(indoor_temperature_sensor, rounded=True, with_unit=True) }}
{%- endif -%}
indoor_temp_unit: >
{%- if indoor_temperature_sensor.split(".")[0] == "climate" -%}
{%- set unit = state_attr(indoor_temperature_sensor, "temperature_unit") -%}
{{ unit if unit is string and unit | length > 0 else temperature_units }}
{%- else -%}
{{ "" }}
{%- endif -%}
indoor_temp: >
{%- if indoor_temperature_sensor.split(".")[0] == "climate" -%}
{{ indoor_temp_raw | string ~ " " ~ indoor_temp_unit if is_number(indoor_temp_raw) else none }}
{%- else -%}
{{ indoor_temp_raw }}
{%- endif -%}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
indoor_temp_trimmed: >
{{ indoor_temp | regex_replace('\s+', ' ') | trim }}
- condition: '{{ indoor_temp_trimmed != "" }}'
Expand Down
Loading