feat: course messaging improvements #141
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnr
reviewed
Apr 30, 2025
| @@ -278,6 +279,10 @@ public class CourseContainerViewModel: BaseCourseViewModel { | |||
| do { | |||
| let courseDeadlineInfo = try await interactor.getCourseDeadlineInfo(courseID: courseID) | |||
| withAnimation { | |||
| self.canShowBanner = interactor.canShowBanner( | |||
There was a problem hiding this comment.
Using a withAnimation block inside a ViewModel is bad practice (I realize you didn't add it, but let's try to avoid it) - it can lead to UI problems and violates the principle that a ViewModel shouldn't handle UI logic, but is responsible for business logic and states
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LEARNER-10505: Course messaging improvements
Description
This PR improves the user experience on the course screen by making all banners dismissible and persisting their dismissal state for 24 hours.
What's Changed
✕) button at the top-right corner.Preview
iPhone
iPad