Add critical css - #94
Open
vladcalin-edw wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
I'm not sure how a build flow should look like since critical.css is generated from a running build, yet it's needed for the build in a production environment. That means 2 builds are required to update the critical.css Current workflow steps:
Update: The critical css is now generated and added during build time of Dockerfile |
nileshgulia1
requested changes
Jul 11, 2025
nileshgulia1
left a comment
nileshgulia1
left a comment
Member
There was a problem hiding this comment.
You can push alteast what's considered to be critical, eg, homepage CSS, the header, navigation, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added critical css to the Dockerfile build
Task: https://taskman.eionet.europa.eu/issues/288613