Skip to content

extract_features_from_genbank uses isolate as strain id, if strain is…#123

Open
vinuesa wants to merge 1 commit into
masterfrom
get_hom_dev_PV
Open

extract_features_from_genbank uses isolate as strain id, if strain is…#123
vinuesa wants to merge 1 commit into
masterfrom
get_hom_dev_PV

Conversation

@vinuesa

@vinuesa vinuesa commented Sep 15, 2025

Copy link
Copy Markdown
Collaborator

extract_features_from_genbank in phyTools.pm now uses isolate as a strain ID if the strain attribute is undefined.

@eead-csic-compbio eead-csic-compbio self-assigned this Sep 16, 2025
@eead-csic-compbio

Copy link
Copy Markdown
Owner

Thanks @vinuesa , I guess

elsif($f->has_tag('isolate') and !$f->has_tag('strain'))

should be simply

elsif($f->has_tag('isolate'))

Can you please propagate this change to all extract_*_from_genbank subs?

@vinuesa

vinuesa commented Sep 17, 2025

Copy link
Copy Markdown
Collaborator Author

Hi @eead-csic-compbio, the proposed code snippet avoids overwriting the strain qualifier in the few cases when both strain and isolate are defined in the GenBank file, which can differ, resulting in the isolate tag being assigned to strain. What do you think?

@eead-csic-compbio

Copy link
Copy Markdown
Owner

Hola @vinuesa , then I guess it should be something like this?

elsif($strain eq ''  && $f->has_tag('isolate'))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants