-
Notifications
You must be signed in to change notification settings - Fork 4
Log mapper and reducer stderr #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #86 +/- ##
============================================
- Coverage 96.98% 79.18% -17.80%
============================================
Files 4 4
Lines 265 269 +4
============================================
- Hits 257 213 -44
- Misses 8 56 +48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, is it safe to merge with the Codecov test failing?
Send stderr produced by mapper or reducer to logger.warning.
We suggest writing debug messages to stderr. However, stderr is swallowed unless there's a non-zero exit. Instead, we should pass this output through to the user.
Validation
Start with a sample MapReduce program. Edit map.py and reduce.py to write the stderr. Then run. ALso try with verbose.