Skip to content

Conversation

@awdeorio
Copy link
Contributor

@awdeorio awdeorio commented Oct 29, 2025

Send stderr produced by mapper or reducer to logger.warning.

We suggest writing debug messages to stderr. However, stderr is swallowed unless there's a non-zero exit. Instead, we should pass this output through to the user.

Validation

Start with a sample MapReduce program. Edit map.py and reduce.py to write the stderr. Then run. ALso try with verbose.

$ madoop --example
$ madoop \
  -input example/input \
  -output example/output \
  -mapper example/map.py \
  -reducer example/reduce.py

$ madoop \
  --verbose \
  -input example/input \
  -output example/output \
  -mapper example/map.py \
  -reducer example/reduce.py

@awdeorio awdeorio requested a review from garv8 October 29, 2025 13:45
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.18%. Comparing base (0bbffe2) to head (2abbd1e).
⚠️ Report is 19 commits behind head on develop.

Files with missing lines Patch % Lines
madoop/mapreduce.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop      #86       +/-   ##
============================================
- Coverage    96.98%   79.18%   -17.80%     
============================================
  Files            4        4               
  Lines          265      269        +4     
============================================
- Hits           257      213       -44     
- Misses           8       56       +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@garv8 garv8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is it safe to merge with the Codecov test failing?

@awdeorio awdeorio merged commit 2f41481 into develop Oct 31, 2025
1 of 3 checks passed
@awdeorio awdeorio deleted the warn-stderr branch October 31, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants