Skip to content

KeepProcessor: Process files that are not in wildcard#28

Merged
eed3si9n merged 1 commit intoeed3si9n:developfrom
shanielh:feature/keep-processor-process-whole-files
Dec 16, 2022
Merged

KeepProcessor: Process files that are not in wildcard#28
eed3si9n merged 1 commit intoeed3si9n:developfrom
shanielh:feature/keep-processor-process-whole-files

Conversation

@shanielh
Copy link
Copy Markdown
Contributor

So we can find the whole recursive dependencies of the roots.

Related sbt/sbt-assembly#488


private void closureHelper(Set<String> closure, Collection<String> process) {
if (process == null)
private void recursiveProcessDependencies(Set<String> result, Collection<String> roots) {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method was just renamed to be more readable, let me know if you want me to undo this.


private Set<String> curSet;
private byte[] buf = new byte[0x2000];
private Set<String> currentDependenciesSet;
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also renamed for better readability

So we can find the whole recursive dependencies of the roots
Copy link
Copy Markdown
Owner

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @shanielh!

@eed3si9n eed3si9n merged commit 7c88cf0 into eed3si9n:develop Dec 16, 2022
@shanielh shanielh deleted the feature/keep-processor-process-whole-files branch December 18, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants