log - #52
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to improve observability in the game logic by adding more detailed logging around common failure paths (trade, production, tech upgrades, character lifecycle, and API entrypoints).
Changes:
- Added debug/error logs for various early-return failure conditions in gaming managers (trade/produce/uplevel/teams).
- Added additional logs around character creation/activation and gameplay actions (move/harvest/load/etc.).
- Minor formatting/bracing edits alongside the logging additions.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| logic/Gaming/Uplevel.cs | Adds logs for failure paths during tech upgrades. |
| logic/Gaming/Trade.cs | Adds logs for trade validation/failure paths. |
| logic/Gaming/Teams.cs | Adds logs for invalid tech/score updates. |
| logic/Gaming/Produce.cs | Adds logs for production start/failure/error paths. |
| logic/Gaming/Game.cs | Adds logs to public API entrypoints on failure. |
| logic/Gaming/CharacterManager.cs | Adds logs for character lifecycle and collision/spawn checks. |
| logic/Gaming/ActionManager.cs | Adds logs for stop/harvest/load actions. |
| logic/GameEngine/MoveEngine.cs | Adjusts using directive (currently introduces a compile issue). |
| logic/GameClass/GameObj/Map/Map.cs | Adds braces and logs on remove failures (one unreachable). |
| logic/GameClass/GameObj/Character.cs | Adds logs around state/load handling (introduces syntax/unreachable-code issues). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@copilot apply changes based on the comments in this thread |
lch24
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add log
Descriptions of this pull request:
No additional description.