Revert "added PDK variable" #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RTimothyEdwards
suggested changes
Sep 28, 2022
Contributor
RTimothyEdwards
left a comment
RTimothyEdwards
left a comment
There was a problem hiding this comment.
I think most of the changes are okay. It's just that the .mag files should not have been changed because it breaks the file format. Instead, magic Tcl scripts that use the "load" command should use "load -force" to ensure that the top level layouts and its dependencies are converted to the PDK variant being used.
So I suggest not reverting the code, but just reverting the .mag files if that's possible, and just changing them back to "tech sky130A" with a new pull request, if not.
Contributor
|
This relates to issue #31 |
Contributor
|
@RTimothyEdwards I couldn't find any |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #26