Skip to content

Commit

Permalink
MNT: Pin PyInstaller==6.9 where Linux build still execs
Browse files Browse the repository at this point in the history
PyInstaller 6.10+ results in:

	Traceback (most recent call last):
	  File "run.py", line 2, in <module>
		import efck.__main__
	  File "PyInstaller/loader/pyimod02_importers.py", line 378, in exec_module
	  File "efck/__main__.py", line 61, in <module>
		main()
	  File "efck/__main__.py", line 53, in main
		from .config import load_config
	  File "PyInstaller/loader/pyimod02_importers.py", line 378, in exec_module
	  File "efck/config.py", line 6, in <module>
		from .tabs import EmojiTab
	ImportError: cannot import name 'EmojiTab' from 'efck.tabs' (dist/efck-chat-keyboard/_internal/efck/tabs/__init__.pyc)
	[PYI-2785842:ERROR] Failed to execute script 'run' due to unhandled exception!
  • Loading branch information
kernc committed Feb 6, 2025
1 parent 35975ff commit 6ca24ff
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packaging/pyinstaller.spec
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ a = Analysis(
win_no_prefer_redirects=False,
win_private_assemblies=False,
cipher=block_cipher,
noarchive=False,
noarchive=False, # Setting this to False may fix PyInstaller build
)

# DO NOT remove system libs
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
'dev': [
'flake8',
'coverage',
'pyinstaller',
'pyinstaller == 6.9',
'pillow', # for pyinstaller
],
'extra': [
Expand Down

0 comments on commit 6ca24ff

Please sign in to comment.