Skip to content

Add 004_triples.links#38

Open
Yi-Zhou-01 wants to merge 10 commits intoeffect-handlers:mainfrom
Yi-Zhou-01:triples_links
Open

Add 004_triples.links#38
Yi-Zhou-01 wants to merge 10 commits intoeffect-handlers:mainfrom
Yi-Zhou-01:triples_links

Conversation

@Yi-Zhou-01
Copy link

Add 004_triples.links

@jO-Osko
Copy link
Collaborator

jO-Osko commented Jul 28, 2022

Thanks for the contribution.
The code looks good and is suitable to be merged as is.

Could you also update links Makefile, add the workflow badge and include the benchmark in the workflow file?

I just merged the new version that updates the workflow file, so you might need to rebase your branch.

This will automatically run the benchmark, test it and display the result in the readme.

If you need any help, don't hesitate to ask (and point out if any documentation about this is missing).
If you don't want to do this by yourself, I am also ok with fixing this by myself.

@Yi-Zhou-01
Copy link
Author

Hi, thanks for your comment. I just checked the Makefile and workflow files, but I'm not sure what to update. If you'd like to update it yourself, please go ahead and do it. Or I could update it myself as well, it's just that I might need a bit of help about how the Makefile and workflow files work.

@jO-Osko
Copy link
Collaborator

jO-Osko commented Aug 5, 2022

Thanks for merging the main branch!

I added links to CI and prepared a structure of Makefile. Could you add the necessary commands specific to links?
Makefile is just a sequence of shell instructions, so you just need to provide the proper commands to compile and run links. I fiddled with it a bit, but couldn't find a nice way to compile the files :(

The commands are run inside links docker container, and links executable is located at /home/ubuntu/.opam/4.08.0/bin/linx, but is not included in the PATH, so you have to invoke it with full path inside the Makefile. The commands in Makefile are run in benchmarks/links/ folder, keep that in mind when writing compile/run commands.

Specifically:
Update all: to compile all links files and then run the resulting executables using hyperfine (the examples are in the comments)
Update parts that compile and run specific benchmarks - this enables the CI to run and test a particular benchmark.

The relevant Makefile is:
https://github.com/effect-handlers/effect-handlers-bench/pull/38/files#diff-19ae85fd55ae36d8e2818cb689b103006953e594f75a7f8bc4a4db610120e119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants