[codex] Increase AdMob revenue surfaces#48
Draft
John Dlugokecki (jdlugo) wants to merge 1 commit into
Draft
Conversation
0285790 to
dfb9b82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR ports the AdMob revenue work onto the current
mainbranch andCronica.xcodeprojproject structure:Publishing note
The previous PR branch was based on an older local branch that had drifted from upstream and carried large screenshot asset history. This update replaces it with a single clean commit on top of current
main, avoiding those oversized assets and resolving the GitHub merge conflict.Validation
xcodebuild test -project Cronica.xcodeproj -scheme "Cronica (EN-US)" -destination 'platform=iOS Simulator,name=iPhone 17,OS=26.2' -only-testing:"Cronica Tests/AdCoordinatorTests" -only-testing:"Cronica Tests/AdStartupCoordinatorTests" -only-testing:"Cronica Tests/AdConfigurationTests" -only-testing:"Cronica Tests/AdGatingTests"git diff --check HEAD~1..HEAD