Skip to content

Conversation

MrSmallLiu
Copy link

@MrSmallLiu MrSmallLiu commented Jul 9, 2019

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@atian25 atian25 requested a review from dead-horse July 9, 2019 08:26
}

async didLoad() {
// 请将你的插件项目中 app.beforeStart 中的代码置于此处。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

去掉注释

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要把 loader 改造成 async function,否则你这里的变更有问题

@dennisleung
Copy link

这个pr有啥进展吗?egg-sequelize的启动时间可以放到willReady不?给上层异步注入db配置留出口子。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants