fix(serialization): replace JsonCamelCaseStringEnumConverter with custom SwapStyleEnumConverter #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tom SwapStyleEnumConverter Fixes #51 - This commit introduces a new `SwapStyleEnumConverter` to handle the serialization of the `SwapStyle` enum. This change also updates the test case in `HtmxHeadOutletTest.cs` to use correct serialized value.
egil
reviewed
May 14, 2024
egil
reviewed
May 14, 2024
egil
requested changes
May 14, 2024
Changed the visibility of the SwapStyleEnumConverter class from public to internal. This modification restricts its accessibility, enhancing encapsulation and preventing unintended usage outside the assembly.
egil
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51 - This commit introduces a new
SwapStyleEnumConverterto handle the serialization of theSwapStyleenum. This change also updates the test case inHtmxHeadOutletTest.csto use correct serialized value.