Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(serialization): replace JsonCamelCaseStringEnumConverter with custom SwapStyleEnumConverter #52

Merged
merged 2 commits into from
May 15, 2024

Conversation

tanczosm
Copy link
Collaborator

Fixes #51 - This commit introduces a new SwapStyleEnumConverter to handle the serialization of the SwapStyle enum. This change also updates the test case in HtmxHeadOutletTest.cs to use correct serialized value.

…tom SwapStyleEnumConverter

Fixes #51 - This commit introduces a new `SwapStyleEnumConverter` to handle the serialization of the `SwapStyle` enum. This change also updates the test case in `HtmxHeadOutletTest.cs` to use correct serialized value.
Copy link
Owner

@egil egil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets keep the types internal unless explicitly needed to be public

Changed the visibility of the SwapStyleEnumConverter class from public to internal. This modification restricts its accessibility, enhancing encapsulation and preventing unintended usage outside the assembly.
@egil egil enabled auto-merge (rebase) May 15, 2024 07:27
@egil egil disabled auto-merge May 15, 2024 07:27
@egil egil merged commit 2b2becd into main May 15, 2024
12 checks passed
@egil egil deleted the fix-swapstyle-serialization branch May 15, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SwapStyle enum serialization is incorrect
2 participants