TICKET:: HCMPRE-2294,HCMPRE-2256,HCMPRE-2257,HCMPRE-2387 #2298

pitabash-eGov · 2025-04-01T05:09:25Z

HRMS modules changes:

digit-ui-component is used
custom component is replaced with digit component .

Summary by CodeRabbit

New Features
- Integrated new HRMS functionality to enhance employee management, including streamlined interfaces for creating, editing, and reviewing employee data.
- Introduced dynamic action prompts for common tasks such as activation, deactivation, and password updates.
- Enhanced search and navigation experiences with improved breadcrumb trails and assignment management.
- Added new components for managing campaign assignments, employee details, and inbox searches.
- Implemented new configuration options for HRMS functionalities, including role assignments and jurisdiction management.
- Expanded proxy routes to accommodate new HRMS endpoints.
Style Enhancements
- Refined visual layouts and updated form styles to deliver a more consistent and user-friendly interface.

into hrms_upgrade

…ustomization

into hrms_upgrade

…reen then move to other screen

into hrms_upgrade

coderabbitai · 2025-04-01T05:09:32Z

Caution

Review failed

Failed to post review comments.

📝 Walkthrough

Walkthrough

The changes integrate HRMS components into the Digit UI application. New import and initialization calls for HRMS have been added in multiple entry point files. Additionally, stylesheet links and SCSS files have been updated or added for HRMS-specific styling. Several UI customization files, proxy routes, and configurations have been restructured. A comprehensive set of new HRMS module components, hooks, services, utilities, constants, and pages have been introduced, supporting operations such as employee creation, detail display, campaign assignment, and search functionalities.

Changes

File(s)	Change Summary
`health/micro-ui/web/health-payments/App.js`, `health/micro-ui/web/micro-ui-internals/example/src/index.js`, `health/micro-ui/web/workbench/App.js`	Imported and initialized `initHRMSComponents` from the HRMS module, integrating HRMS components into Digit UI initialization and updating enabled modules.
`health/micro-ui/web/micro-ui-internals/example/public/index.html`, `health/micro-ui/web/micro-ui-internals/packages/css/src/pages/employee/hrmsupdate.scss`, `health/micro-ui/web/micro-ui-internals/packages/css/src/pages/employee/index.scss`	Updated stylesheet links with new version numbers; added a new SCSS file with custom HRMS styles and imported it into the main CSS.
`health/micro-ui/web/micro-ui-internals/example/src/UICustomizations.js`, `health/micro-ui/web/micro-ui-internals/example/src/setupProxy.js`	Restructured UI customizations (simplified logic, added `SearchDefaultConfigMain`) and introduced several new proxy routes for health endpoints.
`health/micro-ui/web/micro-ui-internals/packages/modules/health-hrms/src/components/...`	Added numerous new HRMS React components (e.g., `EmployeeAction`, `BreadCrumbs`, `CampaignsAssignment`, `DeactivatePopUp`, `BoundaryComponent`, `RolesAssigned`, `Jurisdictions`, `ActionPopUp`) along with new configuration files and constants.
`health/micro-ui/web/micro-ui-internals/packages/modules/health-hrms/src/hooks/...`, `health/micro-ui/web/micro-ui-internals/packages/modules/health-hrms/src/services/...`, `health/micro-ui/web/micro-ui-internals/packages/modules/health-hrms/src/utils/utlis.js`	Introduced custom hooks for HRMS operations (create, update, delete, search, etc.), new service modules for API interactions, and utility functions for data and date processing.
`health/micro-ui/web/micro-ui-internals/packages/modules/health-hrms/src/pages/employee/...`	Implemented new HRMS module pages (e.g., `AssignCampaign`, `CreateEmployee`, `EmployeeDetailScreen`, `InboxSearch`, `ResponseScreen`) for employee management and campaign assignments.

Sequence Diagram(s)

sequenceDiagram
    participant UI as DigitUI
    participant HRMS as HRMS Components
    participant Payment as Payment Components
    UI->>HRMS: initDigitUI() calls initHRMSComponents()
    HRMS-->>UI: HRMS components initialized
    UI->>Payment: initDigitUI() calls initPaymentComponents()
    Payment-->>UI: Payment components initialized

Suggested reviewers

nipunarora-eGov
nabeelmd-eGov
jagankumar-egov

Poem

I'm a happy little bunny,
Hopping through code so sunny.
HRMS joins our grand parade,
With hooks and pages freshly made.
🎉 Tails up, cheers all around,
For new features safe and sound!
🐇 Hop on to the updated ground.

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

into hrms_upgrade

Ramkrishna-egov

@pitabash-eGov Resolve the code comments

health/micro-ui/web/micro-ui-internals/example/public/index.html

Ramkrishna-egov · 2025-04-03T17:14:35Z

...h/micro-ui/web/micro-ui-internals/packages/modules/health-hrms/src/components/Utils/index.js

+    return projectName;
+}
+
+export const getHighLevelProjects = (projectDetails) => {


@pitabash-eGov Please check this if this util is necessary, and if its necessary the Enums are hardcoded, Please refer from boundary Order from boundary search API

...h/micro-ui/web/micro-ui-internals/packages/modules/health-hrms/src/components/Utils/index.js

Ramkrishna-egov · 2025-04-03T17:16:56Z

...icro-ui/web/micro-ui-internals/packages/modules/health-hrms/src/components/employeeAction.js

+    }
+
+    useEffect(() => {
+        switch (action) {


@pitabash-eGov Add the actions to MDMS, Create a new master and refer from MDMS

TODO: need to change

...ui/web/micro-ui-internals/packages/modules/health-hrms/src/pages/employee/employeeDetails.js

Ramkrishna-egov · 2025-04-03T17:37:05Z

health/micro-ui/web/micro-ui-internals/packages/modules/health-hrms/src/services/emp_details.js

+
+    // Fetch project details associated with the staff
+    const response = await Digit.CustomService.getResponse({
+      url: Urls.hcm.searchProject,  // API endpoint for project search


@pitabash-eGov useCustomAPIhook can be used, here instead of Digit.CustomService.getRespons

health/micro-ui/web/micro-ui-internals/packages/modules/health-hrms/src/services/urls.js

Ramkrishna-egov · 2025-04-03T17:40:49Z

health/micro-ui/web/micro-ui-internals/packages/modules/health-hrms/src/services/urls.js

+  UserSearch: "/user/_search",
+  UserLogout: "/user/_logout",
+
+  Shortener: "/egov-url-shortening/shortener",


@pitabash-eGov Add url shortner context path as optional

health/micro-ui/web/micro-ui-internals/packages/modules/health-hrms/src/services/urls.js

into hrms_upgrade

…to support the unified-qa in setProxy

health/micro-ui/web/micro-ui-internals/packages/modules/health-hrms/src/utils/utlis.js

+      case "Landline":
+        return /^[0-9]{11}$/i;
+      case "PropertyID":
+        return /^[a-zA-z0-9\s\\/\-]$/i;


To fix the problem, we need to correct the overly permissive range A-z to accurately match only the intended characters. The correct range should be A-Za-z to include all uppercase and lowercase letters without including unintended special characters.

Update the regular expression on line 70 to use A-Za-z instead of A-z.

Ensure that the functionality remains the same by only changing the character range in the regular expression.

health/micro-ui/web/micro-ui-internals/packages/modules/health-hrms/src/utils/utlis.js

+      case "IFSC":
+        return /^[A-Z]{4}0[A-Z0-9]{6}$/;
+      case "ApplicationNo":
+        return /^[a-zA-z0-9\s\\/\-]$/i;


To fix the problem, we need to correct the regular expression by replacing the overly permissive range A-z with the correct range A-Z. This will ensure that only uppercase letters are matched, along with the other intended characters.

Locate the regular expression in the file health/micro-ui/web/micro-ui-internals/packages/modules/health-hrms/src/utils/utlis.js.

Replace the range A-z with A-Z in the regular expressions on lines 70 and 98.

No additional methods, imports, or definitions are needed to implement this change.

into hrms_upgrade

pitabash-eGov added 29 commits February 7, 2025 17:20

TICKET: 2256, new component upgrade in progress for createscreen

8f989e9

boundary component added to formcomposer

54bbc86

multi selectdropdown impel issue fixed and formcomposerv2 used

87bd389

response screen added

ff7a4e6

API integration done for create employee screen

b04aa0b

employee create service API integerated

fe21c51

create assignment screen static screen and API integration done

aa642ab

update user detail API integration issue fixed

1a50e8f

response message and button functionality changed as per screen

4533af1

Merge branch 'console' of https://github.com/egovernments/DIGIT-Frontend

c9f4749

into hrms_upgrade

new config implemented in order to prevent unnecessary custom component

23f08ad

Merge branch 'console' of https://github.com/egovernments/DIGIT-Frontend

0e23d0c

into hrms_upgrade

inbox search screen is in progress, customized the table data in UI c…

4414025

…ustomization

edit screen completed and deactivate pop up screen is in progress

13ab8e0

deactivate user deatils added

b44aaa0

Merge branch 'console' of https://github.com/egovernments/DIGIT-Frontend

d3657d2

into hrms_upgrade

working on inbox serach

fef95e1

component version upgrade an ddebugger removed and other bug fixes

b3d6579

bug fixes done

67f3aea

worked on activate employee

52d8b6b

history.push is replace with history.push as to remove the current sc…

f586931

…reen then move to other screen

digit-ui-component version upgraded and chnages done in the config file

9fb4273

Merge branch 'console' of https://github.com/egovernments/DIGIT-Frontend

04d90c7

into hrms_upgrade

inbox config issue in progress

3f73d11

issues fixed in the create and edit screen

694132c

removed the console.log from the code

c390513

added code comments

5163b13

mdms config added for the inbox screen

47d4071

Merge branch 'console' of https://github.com/egovernments/DIGIT-Frontend

d33de7b

into hrms_upgrade

pitabash-eGov requested a review from Ramkrishna-egov April 1, 2025 05:09

pitabash-eGov self-assigned this Apr 1, 2025

pitabash-eGov requested a review from a team as a code owner April 1, 2025 05:09

pitabash-eGov added 2 commits April 1, 2025 10:58

debugger removed

0e902e3

Merge branch 'console' of https://github.com/egovernments/DIGIT-Frontend

026baf9

into hrms_upgrade

Ramkrishna-egov requested changes Apr 3, 2025

View reviewed changes

Ramkrishna-egov self-requested a review April 3, 2025 17:43

pitabash-eGov and others added 10 commits April 4, 2025 11:52

working on PR comments: in progress.

7796197

console removed

e211300

hrms module is integrated in workbench

7e39fdf

projectContextPath changed to health-project for QA

c11a03e

health-prefixed added in the project search adn staff search url for QA

12106fe

@egovernments/digit-ui-module-health-hrms module name changed

2251c9a

Merge branch 'console' of https://github.com/egovernments/DIGIT-Frontend

1767d2f

into hrms_upgrade

added buiild script for health hrms module

b6c6763

Added Health HRMS to workbench workspace

8c65331

upgraded the health-css version from 0.3.1 to 0.3.2 and url enhanced …

225ddf2

…to support the unified-qa in setProxy

Ramkrishna-egov changed the base branch from HCMPRE-246 to console April 8, 2025 15:20

console.log removed

11c88eb

github-advanced-security bot found potential problems Apr 9, 2025

View reviewed changes

pitabash-eGov added 2 commits April 9, 2025 10:50

Merge branch 'console' of https://github.com/egovernments/DIGIT-Frontend

90e0d75

into hrms_upgrade

health-css changed accroding to console branch

bb94d8e

pitabash-eGov requested a review from jagankumar-egov April 9, 2025 05:38

coderabbitai bot previously approved these changes Apr 9, 2025

View reviewed changes

readme file added

52b956c

pitabash-eGov dismissed coderabbitai[bot]’s stale review via 52b956c April 9, 2025 05:59

coderabbitai bot approved these changes Apr 9, 2025

View reviewed changes

@@ -69,3 +69,3 @@
                   case "PropertyID":
-                    return /^[a-zA-z0-9\s\\/\-]$/i;
+                    return /^[a-zA-Za-z0-9\s\\/\-]$/i;
                   case "ElectricityConnNo":

@@ -69,3 +69,3 @@
                   case "PropertyID":
-                    return /^[a-zA-z0-9\s\\/\-]$/i;
+                    return /^[a-zA-Z0-9\s\\/\-]$/i;
                   case "ElectricityConnNo":
@@ -97,3 +97,3 @@
                   case "ApplicationNo":
-                    return /^[a-zA-z0-9\s\\/\-]$/i;
+                    return /^[a-zA-Z0-9\s\\/\-]$/i;
                   case "Password":

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TICKET:: HCMPRE-2294,HCMPRE-2256,HCMPRE-2257,HCMPRE-2387 #2298

TICKET:: HCMPRE-2294,HCMPRE-2256,HCMPRE-2257,HCMPRE-2387 #2298

pitabash-eGov commented Apr 1, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 1, 2025 •

edited

Loading

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Ramkrishna-egov left a comment

Ramkrishna-egov Apr 3, 2025

Ramkrishna-egov Apr 3, 2025

pitabash-eGov Apr 9, 2025

Ramkrishna-egov Apr 3, 2025

Ramkrishna-egov Apr 3, 2025

Check warning

Copilot Autofix

Check warning

Copilot Autofix

TICKET:: HCMPRE-2294,HCMPRE-2256,HCMPRE-2257,HCMPRE-2387 #2298

Are you sure you want to change the base?

TICKET:: HCMPRE-2294,HCMPRE-2256,HCMPRE-2257,HCMPRE-2387 #2298

Conversation

pitabash-eGov commented Apr 1, 2025 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Apr 1, 2025 • edited Loading

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Ramkrishna-egov left a comment

Choose a reason for hiding this comment

Ramkrishna-egov Apr 3, 2025

Choose a reason for hiding this comment

Ramkrishna-egov Apr 3, 2025

Choose a reason for hiding this comment

pitabash-eGov Apr 9, 2025

Choose a reason for hiding this comment

Ramkrishna-egov Apr 3, 2025

Choose a reason for hiding this comment

Ramkrishna-egov Apr 3, 2025

Choose a reason for hiding this comment

Check warning

Copilot Autofix

Check warning

Copilot Autofix

pitabash-eGov commented Apr 1, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 1, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)