Skip to content

FEATURE/HCMPRE-0000 : Updated SheetName and Column Widths #2380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

Swathi-eGov
Copy link
Contributor

@Swathi-eGov Swathi-eGov commented Apr 28, 2025

…tion Bulk Upload

Choose the appropriate template for your PR:

Feature PR

Feature Request

JIRA ID

Module

Description

Related Issues


Bugfix PR

Bugfix Request

JIRA ID

Module

Description

Root Cause

Related Issues


Release PR

Summary by CodeRabbit

  • Enhancements

    • Improved Excel template downloads: All columns now have a fixed width and better text alignment for easier readability.
    • The downloaded XLSX file now uses the provided sheet name or defaults to "template" for clearer file identification.
    • Updated the visual style of the "Download Template" button for a more consistent user interface.
  • Documentation

    • Added a changelog entry for version 1.0.22 detailing updates to the Localization Bulk Upload feature.

@Swathi-eGov Swathi-eGov requested a review from a team as a code owner April 28, 2025 08:20
Copy link
Contributor

coderabbitai bot commented Apr 28, 2025

📝 Walkthrough

Walkthrough

This update introduces a new changelog entry for version 1.0.22, reflecting enhancements to the Localization Bulk Upload feature, particularly changes to sheet naming and column widths. The Excel worksheet generation logic now applies a fixed column width and adjusts cell alignment. Additionally, the download filename for generated Excel files is now dynamic, based on the provided sheet name. A minor UI update changes the button style for downloading the template from "primary" to "secondary" within the employee localization module.

Changes

File(s) Change Summary
.../workbench/CHANGELOG.md Added a changelog entry for v1.0.22, documenting updates to Localization Bulk Upload (sheet name, column width)
.../workbench/src/components/GenerateXlsxNew.js Set fixed column width (40), enabled text wrapping and top alignment, dynamic file name based on sheetName
.../workbench/src/pages/employee/LocalisationAdd.js Changed the "Download Template" button style from "primary" to "secondary"

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI
    participant GenerateXlsxNew

    User->>UI: Click "Download Template"
    UI->>GenerateXlsxNew: Request XLSX file (with sheetName)
    GenerateXlsxNew->>GenerateXlsxNew: Generate worksheet (fixed width, wrap text, top align)
    GenerateXlsxNew->>UI: Return XLSX file (named by sheetName or "template")
    UI->>User: Download XLSX file
Loading

Poem

In the warren where code does dwell,
A template’s width, now fixed as well—
With names that match the user’s call,
And buttons dressed to suit them all.
Changelog notes in tidy rows,
The rabbit cheers as progress grows!
🐇📄✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b186cfd and 9cfe576.

⛔ Files ignored due to path filters (6)
  • micro-ui/web/core/package.json is excluded by !**/*.json
  • micro-ui/web/micro-ui-internals/example/package.json is excluded by !**/*.json
  • micro-ui/web/micro-ui-internals/packages/modules/workbench/package.json is excluded by !**/*.json
  • micro-ui/web/package.json is excluded by !**/*.json
  • micro-ui/web/sandbox/package.json is excluded by !**/*.json
  • micro-ui/web/workbench/package.json is excluded by !**/*.json
📒 Files selected for processing (3)
  • micro-ui/web/micro-ui-internals/packages/modules/workbench/CHANGELOG.md (1 hunks)
  • micro-ui/web/micro-ui-internals/packages/modules/workbench/src/components/GenerateXlsxNew.js (2 hunks)
  • micro-ui/web/micro-ui-internals/packages/modules/workbench/src/pages/employee/LocalisationAdd.js (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.js`: check

**/*.js: check

  • micro-ui/web/micro-ui-internals/packages/modules/workbench/src/components/GenerateXlsxNew.js
  • micro-ui/web/micro-ui-internals/packages/modules/workbench/src/pages/employee/LocalisationAdd.js
🪛 markdownlint-cli2 (0.17.2)
micro-ui/web/micro-ui-internals/packages/modules/workbench/CHANGELOG.md

1-1: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)


1-1: First line in a file should be a top-level heading
null

(MD041, first-line-heading, first-line-h1)


2-2: Lists should be surrounded by blank lines
null

(MD032, blanks-around-lists)

⏰ Context from checks skipped due to timeout of 10000ms (2)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Analyze (actions)
🔇 Additional comments (5)
micro-ui/web/micro-ui-internals/packages/modules/workbench/CHANGELOG.md (1)

1-3: LGTM: Appropriate changelog entry for the feature update.

The addition of version 1.0.22 with details about the Localization Bulk Upload feature improvements properly documents the changes made to sheet naming and column widths.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

1-1: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)


1-1: First line in a file should be a top-level heading
null

(MD041, first-line-heading, first-line-h1)


2-2: Lists should be surrounded by blank lines
null

(MD032, blanks-around-lists)

micro-ui/web/micro-ui-internals/packages/modules/workbench/src/pages/employee/LocalisationAdd.js (1)

788-788: LGTM: Button style changed from primary to secondary.

The button styling change from "primary" to "secondary" for the "Download Template" button helps maintain visual hierarchy in the UI. The download action is now properly styled as a secondary action compared to the "Bulk Upload" primary action.

micro-ui/web/micro-ui-internals/packages/modules/workbench/src/components/GenerateXlsxNew.js (3)

69-69: LGTM: Fixed column width improves consistency.

Setting a fixed column width of 40 for all columns ensures consistent display across the localization template spreadsheet, regardless of content length.


76-76: LGTM: Improved text handling for better readability.

Adding text wrapping with top vertical alignment ensures that longer text entries remain readable within the columns instead of being truncated or hidden.


91-91: LGTM: Dynamic filename improves user experience.

Using the sheet name as part of the download filename (${sheetName || "template"}.xlsx) provides better context to users about the content of the downloaded file.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Swathi-eGov Swathi-eGov changed the title FEATURE/HCMPRE:0000 : Updated SheetName and Column Widths in Localiza… FEATURE/HCMPRE:0000 : Updated SheetName and Column Widths Apr 28, 2025
@Swathi-eGov Swathi-eGov changed the title FEATURE/HCMPRE:0000 : Updated SheetName and Column Widths FEATURE/HCMPRE-0000 : Updated SheetName and Column Widths Apr 28, 2025
@jagankumar-egov jagankumar-egov merged commit 5abd6c7 into develop Apr 28, 2025
8 of 10 checks passed
@jagankumar-egov jagankumar-egov deleted the FEATURE/HCMPRE-0000 branch April 28, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants