V0.4.1 #3337
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ import { useTranslation } from "react-i18next"; | |
| import { PopUp, Button, Toast, Dropdown, FileUpload, FieldV1 } from "@egovernments/digit-ui-components"; | ||
| import { convertEpochToDate } from "../../utils/utlis"; | ||
|
|
||
| const DeactivatePopUp = ({bussnessBtnLabel, label, onClose, onSubmit,reasonMsg }) => { | ||
| const { t } = useTranslation(); | ||
| const tenantId = Digit.ULBService.getCurrentTenantId(); | ||
|
|
||
|
|
@@ -42,7 +42,7 @@ const DeactivatePopUp = ({bussnessBtnLabel, label, onClose, onSubmit }) => { | |
| children={[ | ||
| <div className="comment-section"> | ||
| <div className="comment-label"> | ||
| {t(reasonMsg?`HR_ACTIVATION_REASON`:`HR_DEACTIVATION_REASON`)} | ||
| <span className="required"> *</span> | ||
| </div> | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -78,17 +78,39 @@ const EmployeeDetailScreen = () => { | |
| }; | ||
|
|
||
| const deActivateUser = async (comment, date, reason, order) => { | ||
| let updatedDeactivationDetails = []; | ||
|
|
||
| const existingEmployee = data?.Employees[0]; | ||
|
|
||
| if (existingEmployee.deactivationDetails && existingEmployee.deactivationDetails.length > 0) { | ||
| // Update the first object | ||
| updatedDeactivationDetails = existingEmployee.deactivationDetails.map((item, index) => | ||
| index === 0 | ||
| ? { | ||
| ...item, | ||
| effectiveFrom: Date.now(), | ||
| reasonForDeactivation: reason, | ||
| remarks: order, | ||
| orderNo: comment, | ||
| } | ||
| : item | ||
| ); | ||
| } else { | ||
| // Create a new object if no existing objects | ||
| updatedDeactivationDetails = [ | ||
| { | ||
| effectiveFrom: Date.now(), | ||
| reasonForDeactivation: reason, | ||
| remarks: order, | ||
| orderNo: comment, | ||
| }, | ||
| ]; | ||
| } | ||
|
|
||
| let employeeData = { | ||
| ...data?.Employees[0], // Keep existing data | ||
| isActive: false, // Update isActive to false | ||
| deactivationDetails: updatedDeactivationDetails, | ||
| }; | ||
|
|
||
|
Comment on lines
80
to
115
Contributor
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: find . -type f -name "employeeDetails.js" | grep -E "health-hrms|health/micro-ui"Repository: egovernments/DIGIT-Frontend Length of output: 178 🏁 Script executed: wc -l ./health/micro-ui/web/micro-ui-internals/packages/modules/health-hrms/src/pages/employee/employeeDetails.jsRepository: egovernments/DIGIT-Frontend Length of output: 182 🏁 Script executed: sed -n '60,130p' ./health/micro-ui/web/micro-ui-internals/packages/modules/health-hrms/src/pages/employee/employeeDetails.js | cat -nRepository: egovernments/DIGIT-Frontend Length of output: 3007 🏁 Script executed: sed -n '1,60p' ./health/micro-ui/web/micro-ui-internals/packages/modules/health-hrms/src/pages/employee/employeeDetails.js | cat -nRepository: egovernments/DIGIT-Frontend Length of output: 2988 🏁 Script executed: grep -n "deActivateUser" ./health/micro-ui/web/micro-ui-internals/packages/modules/health-hrms/src/pages/employee/employeeDetails.jsRepository: egovernments/DIGIT-Frontend Length of output: 202 🏁 Script executed: sed -n '500,545p' ./health/micro-ui/web/micro-ui-internals/packages/modules/health-hrms/src/pages/employee/employeeDetails.js | cat -nRepository: egovernments/DIGIT-Frontend Length of output: 1705 🏁 Script executed: grep -n "setOpenModal(true)" ./health/micro-ui/web/micro-ui-internals/packages/modules/health-hrms/src/pages/employee/employeeDetails.jsRepository: egovernments/DIGIT-Frontend Length of output: 114 🏁 Script executed: sed -n '450,500p' ./health/micro-ui/web/micro-ui-internals/packages/modules/health-hrms/src/pages/employee/employeeDetails.js | cat -nRepository: egovernments/DIGIT-Frontend Length of output: 2073 🏁 Script executed: sed -n '200,250p' ./health/micro-ui/web/micro-ui-internals/packages/modules/health-hrms/src/pages/employee/employeeDetails.js | cat -nRepository: egovernments/DIGIT-Frontend Length of output: 1850 🏁 Script executed: sed -n '215,225p' ./health/micro-ui/web/micro-ui-internals/packages/modules/health-hrms/src/pages/employee/employeeDetails.js | cat -nRepository: egovernments/DIGIT-Frontend Length of output: 398 Add defensive null-check and reuse The
A safer version: + const existingEmployee = data?.Employees?.[0];
+ if (!existingEmployee) {
+ return;
+ }
+
let updatedDeactivationDetails = [];
-
- const existingEmployee = data?.Employees[0];
if (existingEmployee.deactivationDetails && existingEmployee.deactivationDetails.length > 0) {
// Update the first object
updatedDeactivationDetails = existingEmployee.deactivationDetails.map((item, index) =>
index === 0
? {
...item,
effectiveFrom: Date.now(),
reasonForDeactivation: reason,
remarks: order,
orderNo: comment,
}
: item
);
} else {
// Create a new object if no existing objects
updatedDeactivationDetails = [
{
effectiveFrom: Date.now(),
reasonForDeactivation: reason,
remarks: order,
orderNo: comment,
},
];
}
let employeeData = {
- ...data?.Employees[0],
+ ...existingEmployee,
isActive: false,
deactivationDetails: updatedDeactivationDetails,
};🤖 Prompt for AI Agents |
||
| try { | ||
|
|
@@ -179,7 +201,19 @@ const EmployeeDetailScreen = () => { | |
| }; | ||
|
|
||
| if (isLoading || isMDMSLoading) { | ||
| return ( | ||
| <div | ||
| style={{ | ||
| display: "flex", | ||
| justifyContent: "center", // horizontal center | ||
| alignItems: "center", // vertical center | ||
| height: "100vh", // take full viewport height | ||
| width: "100%", // full width | ||
| }} | ||
| > | ||
| <Loader /> | ||
| </div> | ||
| ); | ||
| } | ||
|
|
||
| return ( | ||
|
|
@@ -407,7 +441,7 @@ const EmployeeDetailScreen = () => { | |
| } | ||
| /> | ||
| ) : ( | ||
| <NoResultsFound /> | ||
| ); | ||
| }, | ||
| }, | ||
|
|
@@ -492,6 +526,7 @@ const EmployeeDetailScreen = () => { | |
| onSubmit={(comment, date, reason, order) => { | ||
| deActivateUser(comment, date, reason, order); | ||
| }} | ||
| reasonMsg={false} | ||
| /> | ||
| )} | ||
|
|
||
|
|
@@ -505,6 +540,7 @@ const EmployeeDetailScreen = () => { | |
| onSubmit={(comment, date, reason, order) => { | ||
| activateUser(comment, date, reason, order); | ||
| }} | ||
| reasonMsg={true} | ||
| /> | ||
| )} | ||
| </React.Fragment> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,10 +7,22 @@ | |
| <link | ||
| href="https://fonts.googleapis.com/css2?family=Roboto+Condensed:wght@400;500;700&family=Roboto:wght@400;500;700&display=swap" | ||
| rel="stylesheet" type="text/css" /> | ||
| <link rel="stylesheet" href="https://unpkg.com/@egovernments/digit-ui-css@1.9.0/dist/index.css" /> | ||
| <link rel="stylesheet" href="https://unpkg.com/@egovernments/[email protected].3/dist/index.css" /> | ||
|
Comment on lines
+10
to
+11
Contributor
There was a problem hiding this comment. 🧩 Analysis chainVerify CSS package versions for compatibility and breaking changes. The CSS packages have been updated to newer versions. Please ensure:
🌐 Web query: 💡 Result: I couldn’t find any published release notes or a CHANGELOG entry specifically for @egovernments/digit-ui-css v1.9.0. The package index (jsDelivr) lists a 1.9.0 release (release date shown Oct 23, 2025) but there’s no accompanying changelog or breaking-changes notes on npm/jsDelivr pages. [1][2] If you want, I can:
Which would you like me to do? 🌐 Web query: 💡 Result: I couldn't find a published 0.2.3 release for @egovernments/digit-ui-components-css. The npm package shows latest published version 0.2.0 (with its changelog) — no 0.2.3 release notes or breaking-change entry are available. [1] If you want, I can:
Sources: Correct CSS package version: [email protected] doesn't exist on npm. The @egovernments/digit-ui-components-css package shows latest published version as 0.2.0, not 0.2.3. The version specified in line 11 will fail to resolve. Update to an available version (e.g., 0.2.0 or verify if 0.2.3 exists in an internal registry). Additionally, @egovernments/digit-ui-css v1.9.0 has no published release notes or CHANGELOG entry, so ensure compatibility with the application code through testing. 🤖 Prompt for AI Agents |
||
| <!-- added below css for hcm-workbench module inclusion--> | ||
| <link rel="stylesheet" href="https://unpkg.com/@egovernments/[email protected]/dist/index.css" /> | ||
| <style> | ||
| /* Original rule you provided */ | ||
| .main.digit-home-main{ | ||
| margin-top: 1rem; | ||
| } | ||
| /* Optional: tweak for small screens */ | ||
| @media (max-width: 480px) { | ||
| .main.digit-home-main { | ||
| margin-top: 0.75rem; | ||
| } | ||
| } | ||
| </style> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| <meta name="theme-color" content="#00bcd1" /> | ||
| <title>DIGIT HCM</title> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -51,9 +51,9 @@ | |
| "dependencies": { | ||
| "lodash": "4.17.21", | ||
| "microbundle-crl": "0.13.11", | ||
| "@egovernments/digit-ui-react-components": "1.9.0", | ||
| "@egovernments/digit-ui-svg-components": "1.1.0", | ||
| "@egovernments/digit-ui-components": "0.2.3", | ||
| "react": "17.0.2", | ||
| "react-dom": "17.0.2", | ||
| "react-hook-form": "6.15.8", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,17 +14,17 @@ | |
| ], | ||
| "homepage": "/workbench-ui", | ||
| "dependencies": { | ||
| "@egovernments/digit-ui-libraries": "1.9.2", | ||
| "@egovernments/digit-ui-module-workbench": "1.1.1", | ||
| "@egovernments/digit-ui-module-core": "1.9.0", | ||
| "@egovernments/digit-ui-module-hcmworkbench": "0.1.7", | ||
| "@egovernments/digit-ui-module-utilities": "1.1.0", | ||
| "@egovernments/digit-ui-module-campaign-manager": "0.4.0", | ||
| "@egovernments/digit-ui-module-health-pgr": "0.0.1", | ||
| "@egovernments/digit-ui-module-health-hrms":"0.0.1", | ||
| "@egovernments/digit-ui-react-components": "1.9.0", | ||
| "@egovernments/digit-ui-svg-components": "1.1.0", | ||
| "@egovernments/digit-ui-components": "0.2.3", | ||
| "react": "17.0.2", | ||
| "react-dom": "17.0.2", | ||
| "jsonpath": "^1.1.1", | ||
|
|
@@ -64,11 +64,15 @@ | |
| "**/@babel/traverse": "7.25.9", | ||
| "**/@babel/preset-env": "7.14.0", | ||
| "**/styled-components": "5.0.0", | ||
| "**/@babel/plugin-transform-modules-commonjs": "7.14.0", | ||
| "**/@jridgewell/gen-mapping": "0.3.5", | ||
| "**/polished": "4.2.2", | ||
| "fast-uri": "2.1.0", | ||
| "**/ajv-formats": "2.1.1", | ||
| "**/minimatch": "7.4.6", | ||
| "minimatch": "7.4.6", | ||
| "**/glob": "7.2.3", | ||
| "glob": "7.2.3" | ||
| }, | ||
| "scripts": { | ||
| "start": "react-scripts start", | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial
Fix ternary operator formatting for consistency.
The ternary operator lacks proper spacing, which is inconsistent with common JavaScript style guidelines.
Apply this diff:
📝 Committable suggestion
🤖 Prompt for AI Agents