HCM Campaign Provincial Dashboard - Data Quality KPI's #3661
Conversation
…atch-1 Update tenant-management.yml
Modified tenant config
…atch-1 Update tenant-management.yml
Fixed update tenant configs
…atch-1 Update tenant-management.yml
…atch-1 Update tenant-management.yml
Added update tenant configd
…atch-1 Update tenant-management.yml
…tch-1 Update project-factory-persister.yml
…atch-1 Update tenant-management.yml
HCMPRE-172 adding additional_details column to plan_configuration table
…t-excel-persister-config added persister file in configs for wms report
HCMPRE-503, HCMPRE-513 renaming executionPlanId to campaignId and adding showOnEstimationDashboard to operations.
…ld-indexer updated transformer topic for household in indexer config
[HCMPRE-2644] - HCM Campaign National Dashboard
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (2)
You can disable this status message by setting the WalkthroughThis update introduces a comprehensive set of new YAML and JSON configuration files to the codebase, primarily for indexing, transformation, and persistence of data across various microservices and domains. The changes add or enhance service mappings for event-driven data ingestion, transformation using JOLT specifications, and database persistence with detailed field mappings and enrichment via external APIs and MDMS lookups. Additionally, the CODEOWNERS file is updated to include more reviewers and specify ownership for the Changes
Sequence Diagram(s)sequenceDiagram
participant Kafka
participant Indexer
participant ExternalAPI
participant MDMS
participant Database
Kafka->>Indexer: New event/message (e.g., save-entity-topic)
Indexer->>Indexer: Transform JSON (JOLT spec)
Indexer->>ExternalAPI: Fetch enrichment data (location, workflow, etc.)
Indexer->>MDMS: Fetch master data (tenant, usage, etc.)
ExternalAPI-->>Indexer: Enrichment data
MDMS-->>Indexer: Master data
Indexer->>Database: Persist/Index transformed and enriched data
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.
🛑 Comments failed to post (79)
egov-indexer/egov-url-shortening-indexer.yaml (1)
5-5:
⚠️ Potential issueFix typo in Kafka topic name
The topic is spelledsave-url-shortening-deatilsbut should besave-url-shortening-details. This typo will prevent the indexer from subscribing to the correct topic.egov-persister/bulk-bill-generation-audit.yml (1)
11-11:
⚠️ Potential issueMismatch between column count and placeholders in SQL insert.
The
INSERTlists 6 columns(id,batchoffset,createdtime,tenantid,recordCount,businessservice)but theVALUESclause has 7 placeholders (?,?,?,?,?,?,?), causing a runtime SQL error.Apply this diff to correct the placeholder count:
- - query: INSERT INTO eg_bs_bulkbill_audit (id,batchoffset,createdtime,tenantid,recordCount,businessservice) VALUES (?,?,?,?,?,?,?); + - query: INSERT INTO eg_bs_bulkbill_audit (id,batchoffset,createdtime,tenantid,recordCount,businessservice) VALUES (?,?,?,?,?,?);egov-persister/sunbirdrc-credential-persister.yml (1)
7-11:
⚠️ Potential issueNested
mappings:block appears incorrect and duplicatesisTransaction.The nested
mappings:key under the first operation is not recognized by the persister framework and duplicatesisTransaction. TheisTransaction,isAuditEnabled, andmodulefields should be direct children of the version mapping.Proposed refactor:
@@ - mappings: - isTransaction: true - isAuditEnabled: true - module: sunbirdrc - isTransaction: true + isTransaction: true + isAuditEnabled: true + module: sunbirdrcegov-persister/firenoc-calculator-persister.yml (1)
10-10: 🛠️ Refactor suggestion
Remove invalid tab character to fix YAML syntax.
The tab character beforefirenoctypeon line 10 will cause a parsing error. Replace it with spaces to conform to YAML syntax.Apply this diff:
- - query: INSERT INTO eg_firenoc_billingslab (id, tenantid, isactive , firenoctype, buildingusagetype, calculationtype, uom, fromuom, touom, fromdate, todate, rate, createdby, createddate, lastmodifiedby, lastModifiedDate) VALUES (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?); + - query: INSERT INTO eg_firenoc_billingslab (id, tenantid, isactive, firenoctype, buildingusagetype, calculationtype, uom, fromuom, touom, fromdate, todate, rate, createdby, createddate, lastmodifiedby, lastModifiedDate) VALUES (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?);📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.- query: INSERT INTO eg_firenoc_billingslab (id, tenantid, isactive, firenoctype, buildingusagetype, calculationtype, uom, fromuom, touom, fromdate, todate, rate, createdby, createddate, lastmodifiedby, lastModifiedDate) VALUES (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?);🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 10-10: syntax error: found character '\t' that cannot start any token
(syntax)
egov-indexer/edcr-indexer.yml (1)
1-4:
⚠️ Potential issueFix YAML key casing and indentation.
The root keyServiceMapsshould be lowercase (serviceMaps), and indentation must follow 2 spaces per level to be consistent with other configs. Incorrect casing or indentation will break YAML parsing.Apply this diff:
-ServiceMaps: - serviceName: Edcr Services - version: 1.0.0 - mappings: +serviceMaps: + serviceName: Edcr Services + version: 1.0.0 + mappings:📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.serviceMaps: serviceName: Edcr Services version: 1.0.0 mappings:egov-persister/mdms-persister.yml (2)
40-44:
⚠️ Potential issueCorrect typo in property name.
The propertyobjecIdJsonPathis misspelled; it should beobjectIdJsonPathto match the expected configuration convention, otherwise the ID path may not be recognized.Apply this diff:
- objecIdJsonPath: $.id + objectIdJsonPath: $.id📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.module: MDMS objectIdJsonPath: $.id tenantIdJsonPath: $.tenantId transactionCodeJsonPath: $.uniqueIdentifier auditAttributeBasePath: $.Mdms
76-80:
⚠️ Potential issueCorrect typo in property name.
Similarly, update theobjecIdJsonPathin the update mapping toobjectIdJsonPath.Apply this diff:
- objecIdJsonPath: $.id + objectIdJsonPath: $.id📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.module: MDMS objectIdJsonPath: $.id tenantIdJsonPath: $.tenantId transactionCodeJsonPath: $.uniqueIdentifier auditAttributeBasePath: $.Mdmsegov-persister/death-reg-persister.yml (2)
2-4: 🛠️ Refactor suggestion
Fix YAML indentation
Keys underserviceMaps(serviceName,mappings) are under‑indented (1 space) whereas nested list items are over‑indented. Use 2‑space indentation per level consistently to resolve lint warnings on lines 2–3.
9-12: 🛠️ Refactor suggestion
Align nested list indentation
The nested- queryand- jsonPathitems are misaligned (too many spaces). Adjust these list items to 2‑space increments per level to clear YAML lint warnings at lines 9–12, 39, 89, and 92.Also applies to: 39-39, 89-89, 92-92
🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 9-9: wrong indentation: expected 3 but found 5
(indentation)
[warning] 12-12: wrong indentation: expected 7 but found 9
(indentation)
egov-indexer/searchBody.yml (1)
5-13:
⚠️ Potential issueDuplicate topic mapping
A mapping for topicsample-data-poc-5under servicesamplealready exists inegov-indexer/UserSearchById.yml. Having two index configurations for the same topic risks conflicting behavior. Please consolidate or differentiate these mappings.egov-indexer/UserSearchById.yml (1)
1-1:
⚠️ Potential issueVerify service mapping duplication
This file also defines an index for topicsample-data-poc-5under servicesample. SincesearchBody.ymlcontains a near‑identical mapping, please consolidate to prevent overlapping index definitions.egov-persister/statement-persister.yml (2)
11-11:
⚠️ Potential issueTypo in metadata key
The keyobjecIdJsonPathis misspelled; it should beobjectIdJsonPathto properly reference the object ID in audit metadata. This typo will break audit tracking.
116-118:
⚠️ Potential issueIncorrect
jsonMapsfor ON CONFLICT upsert
In theINSERT ... ON CONFLICTmapping foreg_statement_sor_details,jsonMapsrepeatsauditDetails.lastModifiedByand omitsauditDetails.createdByandauditDetails.createdTimeneeded for the insert portion. Please correct the mapping order to cover both insert (11 placeholders) and update (5 placeholders) parameters without duplicates.egov-persister/pqm-persister.yaml (1)
18-22:
⚠️ Potential issueCorrect JSON path mapping for
sourceType
The SQL placeholder order in the firstINSERT INTO eg_pqm_testsexpectssourceType(10th parameter), but the mapping uses$.tests.*.testType. This will mispopulate thesourceTypecolumn. Update the mapping to:- - jsonPath: $.tests.*.testType + - jsonPath: $.tests.*.sourceTypeegov-persister/pgr-services-persister.yml (3)
124-164:
⚠️ Potential issueConsistent typo in address update mapping
Similar to the insert block,$.service.address.additionDetails(line 155) is misspelled. It should beadditionalDetails.
10-39:
⚠️ Potential issueCritical JSON path mismatches in service insertion mapping
The fieldadditionalDetailat line 25 does not match the payload’sadditionalDetails(plural), causing null inserts intoadditionaldetails.Apply:
- - jsonPath: $.service.additionalDetail + - jsonPath: $.service.additionalDetails📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.- query: INSERT INTO eg_pgr_service_v2(id, tenantid, servicecode, servicerequestid, description, accountid, additionaldetails, applicationstatus, source, createdby, createdtime, lastmodifiedby, lastmodifiedtime) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?); basePath: service jsonMaps: - jsonPath: $.service.id - jsonPath: $.service.tenantId - jsonPath: $.service.serviceCode - jsonPath: $.service.serviceRequestId - jsonPath: $.service.description - jsonPath: $.service.accountId - jsonPath: $.service.additionalDetails type: JSON dbType: JSONB - jsonPath: $.service.applicationStatus - jsonPath: $.service.source - jsonPath: $.service.auditDetails.createdBy - jsonPath: $.service.auditDetails.createdTime - jsonPath: $.service.auditDetails.lastModifiedBy - jsonPath: $.service.auditDetails.lastModifiedTime
41-89:
⚠️ Potential issueTypo in address insertion mapping:
additionDetails
The JSON path$.service.address.additionDetails(line 78) is misspelled and will fail to pick upadditionalDetails.Apply:
- - jsonPath: $.service.address.additionDetails + - jsonPath: $.service.address.additionalDetails📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.- query: INSERT INTO eg_pgr_address_v2(id, tenantid, parentid, doorno, plotno, buildingname, street, landmark, city, pincode, locality, district, region, state, country, latitude, longitude, additionaldetails, createdby, createdtime, lastmodifiedby, lastmodifiedtime) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?); basePath: service.address jsonMaps: - jsonPath: $.service.address.id - jsonPath: $.service.address.tenantId - jsonPath: $.service.id - jsonPath: $.service.address.doorNo - jsonPath: $.service.address.plotNo - jsonPath: $.service.address.buildingName - jsonPath: $.service.address.street - jsonPath: $.service.address.landmark - jsonPath: $.service.address.city - jsonPath: $.service.address.pincode - jsonPath: $.service.address.locality.code - jsonPath: $.service.address.district - jsonPath: $.service.address.region - jsonPath: $.service.address.state - jsonPath: $.service.address.country - jsonPath: $.service.address.geoLocation.latitude - jsonPath: $.service.address.geoLocation.longitude - jsonPath: $.service.address.additionalDetails type: JSON dbType: JSONB - jsonPath: $.service.auditDetails.createdBy - jsonPath: $.service.auditDetails.createdTime - jsonPath: $.service.auditDetails.lastModifiedBy - jsonPath: $.service.auditDetails.lastModifiedTimeegov-indexer/rainmaker-death-indexer.yml (2)
8-14:
⚠️ Potential issueMissing
isBulkandtimeStampFieldproperties.
Other indexer configs explicitly setisBulk: trueand specify atimeStampField. Without these, bulk processing and proper timestamp-based ordering may not function correctly. Please add, for example:isBulk: true timeStampField: $.auditDetails.createdTime # use lastModifiedTime for update if needed🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 8-8: wrong indentation: expected 5 but found 6
(indentation)
[warning] 13-13: wrong indentation: expected 9 but found 10
(indentation)
25-28:
⚠️ Potential issueRemove duplicate
dateofissuemapping.
Lines 25–28 map$.dateofissueto$.Data.dateofissuetwice, which is redundant and may lead to confusion or unintended overwrites. Please remove the duplicate entries.egov-dss-dashboards/dashboard-analytics/RoleDashboardMappingsConf.json (3)
56-59:
⚠️ Potential issueIncorrect FSM dashboard name.
"Facial Sludge Management"appears to be misspelled; the correct term is"Faecal Sludge Management".
136-147:
⚠️ Potential issueCommissioner dashboards missing
name.
Entries forroleId: 7 (Commissioner)include onlyidproperties. For consistency and proper UI rendering, please add corresponding"name"fields for each dashboard.
44-47:
⚠️ Potential issueSpelling error in dashboard name.
"National Urban Relatime Dashboard"contains a typo — "Relatime" should be "Realtime".egov-indexer/service-request-indexer.yml (1)
41-41:
⚠️ Potential issueAdd newline at end of file
YAML Lint reports a missing end-of-file newline. Please add a trailing newline to satisfy thenew-line-at-end-of-filerule.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 41-41: no new line character at the end of file
(new-line-at-end-of-file)
egov-persister/egov-workflow-v2-persister.yml (3)
10-10:
⚠️ Potential issueVerify
processinstanceinsert columns versus JSON mappings
The INSERT addsratingandescalatedcolumns (18 placeholders), but the JSON path forbusinessServiceSlahas a typo (businesssServiceSla) which will misalign the parameter order. Please correct the JSON path and confirm the placeholder count matches.
252-252:
⚠️ Potential issueValidate upsert for
eg_wf_action_v2
The ON CONFLICT clause updatesactive, but ensure the JSON mappings still align and remove any duplicateuuidmappings as noted above.
170-174:
⚠️ Potential issueRemove duplicate UUID mapping
There are two JSON path entries foruuid($.actions.*.uuidand the filter expression). Consolidate to a single mapping to avoid ambiguity.egov-dss-dashboards/dashboard-ingest/DomainConfig.json (2)
307-333:
⚠️ Potential issueDuplicate
idvalue (9) detected
Theid"9"is used for bothBPA_OCandDEATH_CERT. IDs must be unique—update them to distinct values.
280-306:
⚠️ Potential issueDuplicate
idvalue (8) detected
Theid"8"is used for bothSWandBIRTH_CERT. IDs must be unique withindomainConfig. Please renumber to avoid collision.egov-indexer/household-indexer.yml (1)
58-58:
⚠️ Potential issueAdd newline at end of file
YAML Lint flags a missing trailing newline. Please add one to comply with thenew-line-at-end-of-filerule.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 58-58: no new line character at the end of file
(new-line-at-end-of-file)
egov-persister/product-persister.yml (1)
16-20:
⚠️ Potential issueMismatch between column name and JSON mapping for additional details
The INSERT query targets the
additionalDetailscolumn, but the JSON mapping uses$.additionalFields. This inconsistency can lead to empty or incorrect data being persisted.If the payload field is
additionalDetails, update your mapping:- - jsonPath: $.*.additionalFields + - jsonPath: $.*.additionalDetailsAlso apply the same fix in the UPDATE and variant mappings.
egov-indexer/pgr-services.yml (1)
84-92:
⚠️ Potential issueMissing customJsonMapping for reindex mapping
The
pgr-service-reindexmapping definesjsonPath,id, andtimeStampFieldbut lacks a correspondingcustomJsonMappingsection. Without it, the root JSON ($.hits) won't be nested underDataand field mappings won't apply. Please add acustomJsonMappingblock similar to the other mappings.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 87-87: wrong indentation: expected 5 but found 6
(indentation)
[error] 92-92: no new line character at the end of file
(new-line-at-end-of-file)
egov-persister/stock-persister.yml (1)
25-26:
⚠️ Potential issueMismatch between JSON path and database column names
All
jsonPathentries use$.*.additionalFields, but the SQL queries insert/update theadditionalDetailscolumn. This mismatch will result in null values foradditionalDetails. Additionally, in the reconciliation mapping, the SQL column isphysicalRecordedCount, but the JSON uses$.*.physicalCount. Please update the JSON paths to match the column names:- jsonPath: $.*.additionalFields + jsonPath: $.*.additionalDetails - jsonPath: $.*.physicalCount + jsonPath: $.*.physicalRecordedCountAlso applies to: 60-62, 84-86, 109-110, 140-142, 164-166
egov-persister/pgr-migration-batch.yml (1)
119-124:
⚠️ Potential issueTypo in JSONPath field name
The JSON field forbusinessServiceSlais misspelled asbusinesssServiceSla(extra 's'), which doesn't match the SQL columnbusinessServiceSla.Please correct it to:
- - jsonPath: $.ProcessInstances.*.businesssServiceSla + - jsonPath: $.ProcessInstances.*.businessServiceSla📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.- jsonPath: $.ProcessInstances.*.assigner.uuid - jsonPath: $.ProcessInstances.*.stateSla - - jsonPath: $.ProcessInstances.*.businesssServiceSla + - jsonPath: $.ProcessInstances.*.businessServiceSlaegov-persister/fsm-calculator-persister.yaml (4)
82-118: 🛠️ Refactor suggestion
Fix trailing spaces and indent update mappings
Thesave-zeroPricingandupdate-zeroPricingsections contain trailing spaces and indentation errors flagged by YAMLlint.Ensure consistent two-space indentation and remove all trailing spaces on these lines.
🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 82-82: wrong indentation: expected 3 but found 7
(indentation)
[warning] 85-85: wrong indentation: expected 9 but found 10
(indentation)
[error] 86-86: trailing spaces
(trailing-spaces)
[error] 88-88: trailing spaces
(trailing-spaces)
[error] 89-89: trailing spaces
(trailing-spaces)
[error] 90-90: trailing spaces
(trailing-spaces)
[error] 92-92: trailing spaces
(trailing-spaces)
[error] 93-93: trailing spaces
(trailing-spaces)
[error] 98-98: trailing spaces
(trailing-spaces)
[error] 99-99: trailing spaces
(trailing-spaces)
[warning] 100-100: wrong indentation: expected 3 but found 7
(indentation)
[warning] 101-101: too many spaces after colon
(colons)
[error] 102-102: trailing spaces
(trailing-spaces)
[error] 103-103: trailing spaces
(trailing-spaces)
[warning] 104-104: wrong indentation: expected 9 but found 10
(indentation)
[error] 105-105: trailing spaces
(trailing-spaces)
[error] 107-107: trailing spaces
(trailing-spaces)
[error] 110-110: trailing spaces
(trailing-spaces)
[warning] 111-111: wrong indentation: expected 9 but found 16
(indentation)
[error] 112-112: trailing spaces
(trailing-spaces)
[error] 114-114: trailing spaces
(trailing-spaces)
[error] 116-116: trailing spaces
(trailing-spaces)
[error] 118-118: trailing spaces
(trailing-spaces)
43-48: 🛠️ Refactor suggestion
Fix indentation and spacing in second mapping
The second mapping block has extra spaces after colons and inconsistent indentation.Align it with the first mapping (2‑space indent for children):
- - query: INSERT INTO public.eg_billing_slab_auditlog... + - query: INSERT INTO public.eg_billing_slab_auditlog...Committable suggestion skipped: line range outside the PR's diff.
🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 43-43: wrong indentation: expected 3 but found 7
(indentation)
[warning] 44-44: too many spaces after colon
(colons)
[error] 45-45: trailing spaces
(trailing-spaces)
[warning] 46-46: wrong indentation: expected 9 but found 12
(indentation)
[error] 47-47: trailing spaces
(trailing-spaces)
[error] 48-48: trailing spaces
(trailing-spaces)
10-36: 🛠️ Refactor suggestion
Remove trailing spaces and fix list indentation
Lines 10–36 contain trailing spaces and misaligned list items underqueryMaps.Align
- query:entries two spaces underqueryMapsand strip trailing spaces. For example:- queryMaps: - - - query: INSERT INTO public.eg_billing_slab... + queryMaps: + - query: INSERT INTO public.eg_billing_slab...Committable suggestion skipped: line range outside the PR's diff.
🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 10-10: wrong indentation: expected 3 but found 7
(indentation)
[warning] 13-13: wrong indentation: expected 9 but found 10
(indentation)
[error] 16-16: trailing spaces
(trailing-spaces)
[error] 18-18: trailing spaces
(trailing-spaces)
[error] 20-20: trailing spaces
(trailing-spaces)
[error] 22-22: trailing spaces
(trailing-spaces)
[error] 26-26: trailing spaces
(trailing-spaces)
[error] 28-28: trailing spaces
(trailing-spaces)
[error] 36-36: trailing spaces
(trailing-spaces)
1-3: 🛠️ Refactor suggestion
Normalize root indentation
Keys underserviceMaps(serviceName,mappings) use inconsistent indentation (1 space). They should be indented consistently (e.g., 2 spaces):serviceMaps: - serviceName: fsm-calculator - mappings: + serviceName: fsm-calculator + mappings:📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.serviceMaps: serviceName: fsm-calculator mappings:egov-dss-dashboards/dashboard-ingest/transform_bpa_v1.json (1)
15-38:
⚠️ Potential issueTypo in key name
seperator.
The field"seperator"appears misspelled and may not be recognized by downstream processors. It should likely be"separator".Apply this diff to rename all occurrences:
"targetReferences": [ { "fieldName": "applicationNo", "argument": "Data.applicationNo", "dataType": "String", - "seperator": " ", + "separator": " ", "expression": "applicationNo" } ]Repeat for each block under
targetReferences/sourceReferences.egov-indexer/egov-vehicle.yaml (4)
47-56:
⚠️ Potential issueRemove hard‑coded
authTokenfromapiRequest.
Detected a staticauthTokenvalue in the API request payload for the workflow service. Embedding secrets in config is insecure; consider retrieving tokens dynamically from RequestInfo or a secure vault.🧰 Tools
🪛 Gitleaks (8.21.2)
52-52: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
🪛 YAMLlint (1.35.1)
[warning] 47-47: wrong indentation: expected 9 but found 8
(indentation)
[warning] 49-49: too few spaces after comma
(commas)
[warning] 49-49: too few spaces after comma
(commas)
[warning] 49-49: too few spaces after comma
(commas)
[warning] 49-49: too few spaces after comma
(commas)
[warning] 49-49: too few spaces after comma
(commas)
[warning] 49-49: too few spaces after comma
(commas)
[warning] 49-49: too few spaces after comma
(commas)
[warning] 49-49: too few spaces after comma
(commas)
[warning] 49-49: too few spaces after comma
(commas)
[warning] 49-49: too few spaces after comma
(commas)
[warning] 49-49: too few spaces after comma
(commas)
[warning] 49-49: too few spaces after comma
(commas)
[warning] 49-49: too few spaces after comma
(commas)
[warning] 49-49: too few spaces after comma
(commas)
[warning] 49-49: too few spaces after comma
(commas)
[warning] 51-51: wrong indentation: expected 11 but found 10
(indentation)
[warning] 55-55: too few spaces after comma
(commas)
[warning] 55-55: too few spaces after comma
(commas)
[warning] 55-55: too few spaces after comma
(commas)
[warning] 55-55: too few spaces after comma
(commas)
[warning] 55-55: too few spaces after comma
(commas)
[warning] 55-55: too few spaces after comma
(commas)
[warning] 55-55: too few spaces after comma
(commas)
[warning] 55-55: too few spaces after comma
(commas)
[warning] 55-55: too few spaces after comma
(commas)
[warning] 55-55: too few spaces after comma
(commas)
[warning] 55-55: too few spaces after comma
(commas)
[warning] 55-55: too few spaces after comma
(commas)
[warning] 55-55: too few spaces after comma
(commas)
[warning] 55-55: too few spaces after comma
(commas)
[warning] 55-55: too few spaces after comma
(commas)
[warning] 55-55: too few spaces after comma
(commas)
[warning] 55-55: too few spaces after comma
(commas)
[warning] 55-55: too few spaces after comma
(commas)
96-106:
⚠️ Potential issueRemove hard‑coded
authTokenfromapiRequest.
Another staticauthTokenappears in the second workflow call. Replace with a secure, dynamically injected token.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 98-98: wrong indentation: expected 9 but found 8
(indentation)
[warning] 100-100: too few spaces after comma
(commas)
[warning] 100-100: too few spaces after comma
(commas)
[warning] 100-100: too few spaces after comma
(commas)
[warning] 100-100: too few spaces after comma
(commas)
[warning] 100-100: too few spaces after comma
(commas)
[warning] 100-100: too few spaces after comma
(commas)
[warning] 100-100: too few spaces after comma
(commas)
[warning] 100-100: too few spaces after comma
(commas)
[warning] 100-100: too few spaces after comma
(commas)
[warning] 100-100: too few spaces after comma
(commas)
[warning] 100-100: too few spaces after comma
(commas)
[warning] 100-100: too few spaces after comma
(commas)
[warning] 100-100: too few spaces after comma
(commas)
[warning] 100-100: too few spaces after comma
(commas)
[warning] 100-100: too few spaces after comma
(commas)
[warning] 102-102: wrong indentation: expected 11 but found 10
(indentation)
[warning] 106-106: too few spaces after comma
(commas)
[warning] 106-106: too few spaces after comma
(commas)
[warning] 106-106: too few spaces after comma
(commas)
[warning] 106-106: too few spaces after comma
(commas)
[warning] 106-106: too few spaces after comma
(commas)
[warning] 106-106: too few spaces after comma
(commas)
[warning] 106-106: too few spaces after comma
(commas)
[warning] 106-106: too few spaces after comma
(commas)
[warning] 106-106: too few spaces after comma
(commas)
[warning] 106-106: too few spaces after comma
(commas)
[warning] 106-106: too few spaces after comma
(commas)
[warning] 106-106: too few spaces after comma
(commas)
[warning] 106-106: too few spaces after comma
(commas)
[warning] 106-106: too few spaces after comma
(commas)
[warning] 106-106: too few spaces after comma
(commas)
[warning] 106-106: too few spaces after comma
(commas)
[warning] 106-106: too few spaces after comma
(commas)
[warning] 106-106: too few spaces after comma
(commas)
146-154:
⚠️ Potential issueRemove hard‑coded
authTokenfromapiRequest.
The update‑workflow mapping also embeds a static token. Refactor to avoid secret leakage.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 146-146: wrong indentation: expected 9 but found 8
(indentation)
[warning] 149-149: wrong indentation: expected 9 but found 8
(indentation)
[warning] 151-151: too few spaces after comma
(commas)
[warning] 151-151: too few spaces after comma
(commas)
[warning] 151-151: too few spaces after comma
(commas)
[warning] 151-151: too few spaces after comma
(commas)
[warning] 151-151: too few spaces after comma
(commas)
[warning] 151-151: too few spaces after comma
(commas)
[warning] 151-151: too few spaces after comma
(commas)
[warning] 151-151: too few spaces after comma
(commas)
[warning] 151-151: too few spaces after comma
(commas)
[warning] 151-151: too few spaces after comma
(commas)
[warning] 151-151: too few spaces after comma
(commas)
[warning] 151-151: too few spaces after comma
(commas)
[warning] 151-151: too few spaces after comma
(commas)
[warning] 151-151: too few spaces after comma
(commas)
[warning] 151-151: too few spaces after comma
(commas)
[warning] 153-153: wrong indentation: expected 11 but found 10
(indentation)
42-42:
⚠️ Potential issueSyntax error in
indexMappingJSON.
The inline JSON is invalid because the keyvehicleTripis not wrapped in quotes. This will break the parser.Apply this diff (and replicate for all similar occurrences):
-indexMapping: {"Data":{vehicleTrip":{},"tenantData":{}, "history":{},"fsm":{},"fstpPlantInfo":{}}} +indexMapping: {"Data":{"vehicleTrip":{},"tenantData":{},"history":{},"fsm":{},"fstpPlantInfo":{}}}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.indexMapping: {"Data":{"vehicleTrip":{},"tenantData":{},"history":{},"fsm":{},"fstpPlantInfo":{}}}🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 42-42: wrong indentation: expected 7 but found 8
(indentation)
[warning] 42-42: too few spaces after comma
(commas)
[warning] 42-42: too few spaces after comma
(commas)
[warning] 42-42: too few spaces after comma
(commas)
egov-persister/facility-persister.yml (1)
9-19:
⚠️ Potential issueMismatch between SQL column and JSON path.
TheINSERTintohealth.FACILITYtargets theadditionalDetailscolumn, but the mapping uses$.additionalFields. This will causeadditionalDetailsto be unset. Update to$.additionalDetails.egov-persister/referral-management-persister.yml (1)
22-24:
⚠️ Potential issueMismatch JSON path for additionalDetails in queryMaps
The parameter binding usesjsonPath: $.*.additionalFields, but every SQL query references the columnadditionalDetails. This discrepancy will result in missing or null values for theadditionalDetailscolumn on inserts and updates.
Apply this diff to all affected mappings:- - jsonPath: $.*.additionalFields + - jsonPath: $.*.additionalDetailsAlso applies to: 52-54, 98-100, 131-133, 178-180, 209-211
egov-indexer/pgr-migration-batch-indexer.yml (2)
37-40:
⚠️ Potential issueIncorrect JSON path in MDMS filterMapping for Department
The filterMapping usesvalueJsonpath: $.department, but the incoming payload nests department underservice. Update it to:- valueJsonpath: $.department + valueJsonpath: $.service.department
5-12: 🛠️ Refactor suggestion
Batch indexing missing
isBulkflag
This is a batch topic (save-pgr-request-batch) that likely delivers an array of documents. To ensure bulk indexing, addisBulk: trueunder theindexessection:indexes: - name: pgr-services type: general + isBulk: true id: $.service.serviceRequestId jsonPath: $ timeStampField: $.service.auditDetails.lastModifiedTime📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.- topic: save-pgr-request-batch configKey: INDEX indexes: - name: pgr-services type: general isBulk: true id: $.service.serviceRequestId jsonPath: $ timeStampField: $.service.auditDetails.lastModifiedTimeegov-indexer/bpa-inbox-indexer.yml (1)
2-4:
⚠️ Potential issueFix YAML indentation under ServiceMaps
The keysserviceName,version, andmappingsmust be indented by two spaces underServiceMaps:. Incorrect indentation will break YAML parsing.egov-indexer/fire-noc-service.yml (2)
2-5:
⚠️ Potential issueFix YAML indentation under ServiceMaps
EnsureserviceName,version, andmappingsare indented by two spaces underServiceMaps:. The current one-space indent will render the file invalid YAML.
29-34:
⚠️ Potential issueRemove duplicate
buildingsfieldMapping entry
Thebuildingsmapping for$.fireNOCDetails.buildingsappears twice. Delete the redundant block to avoid processing the same field twice:- - inJsonPath: $.fireNOCDetails.buildings - outJsonPath: $.Data.fireNOCDetails.buildingsegov-indexer/pt-inbox-indexer.yml (3)
2-2:
⚠️ Potential issueFix indentation for
serviceName
serviceNamemust be indented two spaces underServiceMaps:to match the pattern used in other indexer configs. Without this, the parser may ignore the key.
76-76:
⚠️ Potential issueAdd newline at end of file
A final newline is required to satisfy many YAML parsers and linters.
5-5:
⚠️ Potential issueCorrect mapping item indentation
The- topic: inbox-property-eventsentry is misaligned. It should sit undermappings:at two additional spaces (total of four spaces from the left margin).egov-persister/birth-death.yml (3)
98-102: 🛠️ Refactor suggestion
Add explicit type for JSONB fields
In the death-certificate insert mapping, declare theadditionalDetailfield withtype: JSONanddbType: JSONBas done in the birth mapping to ensure consistency in the database schema.
1-3:
⚠️ Potential issueStandardize root key naming
This file usesserviceMaps(lower-case “s”), while indexer configs useServiceMaps. Aligning on one casing (e.g.,ServiceMaps) will prevent parsing inconsistencies across modules.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 1-1: wrong new line character: expected \n
(new-lines)
1-137:
⚠️ Potential issueRemove trailing spaces and add newline
Multiple lines have trailing whitespace and the file lacks a final newline. Cleaning these up will ensure compatibility with strict YAML linters.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 1-1: wrong new line character: expected \n
(new-lines)
[error] 26-26: trailing spaces
(trailing-spaces)
[error] 28-28: trailing spaces
(trailing-spaces)
[error] 36-36: trailing spaces
(trailing-spaces)
[error] 37-37: trailing spaces
(trailing-spaces)
[error] 38-38: trailing spaces
(trailing-spaces)
[error] 39-39: trailing spaces
(trailing-spaces)
[error] 50-50: trailing spaces
(trailing-spaces)
[error] 52-52: trailing spaces
(trailing-spaces)
[error] 56-56: trailing spaces
(trailing-spaces)
[error] 59-59: trailing spaces
(trailing-spaces)
[error] 60-60: trailing spaces
(trailing-spaces)
[error] 61-61: trailing spaces
(trailing-spaces)
[error] 63-63: trailing spaces
(trailing-spaces)
[error] 70-70: trailing spaces
(trailing-spaces)
[error] 71-71: trailing spaces
(trailing-spaces)
[error] 94-94: trailing spaces
(trailing-spaces)
[error] 96-96: trailing spaces
(trailing-spaces)
[error] 104-104: trailing spaces
(trailing-spaces)
[error] 105-105: trailing spaces
(trailing-spaces)
[error] 106-106: trailing spaces
(trailing-spaces)
[error] 107-107: trailing spaces
(trailing-spaces)
[error] 118-118: trailing spaces
(trailing-spaces)
[error] 120-120: trailing spaces
(trailing-spaces)
[error] 124-124: trailing spaces
(trailing-spaces)
[error] 127-127: trailing spaces
(trailing-spaces)
[error] 129-129: trailing spaces
(trailing-spaces)
[error] 130-130: trailing spaces
(trailing-spaces)
[error] 131-131: trailing spaces
(trailing-spaces)
[error] 132-132: trailing spaces
(trailing-spaces)
[error] 137-137: no new line character at the end of file
(new-line-at-end-of-file)
egov-indexer/rainmaker-birth-indexer.yml (3)
26-29: 🛠️ Refactor suggestion
⚠️ Potential issueRemove duplicate
dateofissuemapping
Thedateofissuefield appears twice in the save mapping. This redundancy can lead to ambiguous behavior in the index. Please remove the duplicate entry.
2-2:
⚠️ Potential issueCorrect indentation of
serviceName
serviceNameshould be indented two spaces underServiceMaps:to align with the structure of other indexer files.
1-106:
⚠️ Potential issueClean up trailing spaces and add newline
There are trailing whitespace characters and no final newline. Removing them will satisfy YAML parsers and improve cross-editor compatibility.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 1-1: wrong new line character: expected \n
(new-lines)
[warning] 8-8: wrong indentation: expected 5 but found 6
(indentation)
[warning] 14-14: wrong indentation: expected 9 but found 10
(indentation)
[warning] 16-16: wrong indentation: expected 11 but found 10
(indentation)
[error] 19-19: trailing spaces
(trailing-spaces)
[error] 25-25: trailing spaces
(trailing-spaces)
[error] 56-56: trailing spaces
(trailing-spaces)
[warning] 60-60: wrong indentation: expected 5 but found 6
(indentation)
[warning] 65-65: wrong indentation: expected 9 but found 10
(indentation)
[warning] 67-67: wrong indentation: expected 11 but found 10
(indentation)
[error] 70-70: trailing spaces
(trailing-spaces)
[error] 76-76: trailing spaces
(trailing-spaces)
[error] 106-106: no new line character at the end of file
(new-line-at-end-of-file)
egov-indexer/citizen-feedback-indexer.yml (2)
1-76:
⚠️ Potential issueAdd newline at end-of-file
Please add a newline at the end of file to comply with YAML standards and avoid parser warnings.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 5-5: wrong indentation: expected 4 but found 3
(indentation)
[warning] 15-15: too few spaces after comma
(commas)
[warning] 15-15: too few spaces after comma
(commas)
[warning] 15-15: too few spaces after comma
(commas)
[warning] 15-15: too few spaces after comma
(commas)
[warning] 15-15: too few spaces after comma
(commas)
[warning] 15-15: too few spaces after comma
(commas)
[warning] 15-15: too few spaces after comma
(commas)
[warning] 15-15: too few spaces after comma
(commas)
[warning] 15-15: too few spaces after comma
(commas)
[warning] 15-15: too few spaces after comma
(commas)
[warning] 15-15: too few spaces after comma
(commas)
[warning] 17-17: wrong indentation: expected 13 but found 11
(indentation)
[warning] 52-52: wrong indentation: expected 13 but found 11
(indentation)
[warning] 54-54: too few spaces after comma
(commas)
[warning] 54-54: too few spaces after comma
(commas)
[warning] 54-54: too few spaces after comma
(commas)
[warning] 54-54: too few spaces after comma
(commas)
[warning] 54-54: too few spaces after comma
(commas)
[warning] 54-54: too few spaces after comma
(commas)
[warning] 55-55: wrong indentation: expected 44 but found 13
(indentation)
[warning] 55-55: too few spaces after comma
(commas)
[warning] 57-57: wrong indentation: expected 15 but found 13
(indentation)
[warning] 63-63: wrong indentation: expected 17 but found 15
(indentation)
[error] 76-76: no new line character at the end of file
(new-line-at-end-of-file)
5-5:
⚠️ Potential issueFix mapping indentation
The list undermappings:is indented incorrectly (3 spaces before- topic). It should be two spaces undermappings:to maintain consistent YAML structure.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 5-5: wrong indentation: expected 4 but found 3
(indentation)
egov-indexer/fsm-inbox-indexer.yml (1)
1-4:
⚠️ Potential issueFix indentation of top-level keys under ServiceMaps.
TheserviceName,version, andmappingskeys underServiceMaps:must be indented by 2 spaces, not 1. Incorrect indentation will cause YAML parsing errors.Apply:
ServiceMaps: - serviceName: fsm-Event indexer - version: 1.0.0 - mappings: + serviceName: fsm-Event indexer + version: 1.0.0 + mappings:📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.ServiceMaps: serviceName: fsm-Event indexer version: 1.0.0 mappings:egov-indexer/egov-pqm-service.yml (1)
1-4:
⚠️ Potential issueFix indentation of top-level keys under ServiceMaps.
IndentserviceName,version, andmappingsby 2 spaces underServiceMaps:to ensure valid YAML.ServiceMaps: - serviceName: pqm-service inbox - version: 1.0.0 - mappings: + serviceName: pqm-service inbox + version: 1.0.0 + mappings:📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.ServiceMaps: serviceName: pqm-service inbox version: 1.0.0 mappings:egov-indexer/egov-fsm.yml (1)
19-32:
⚠️ Potential issueAvoid hardcoding
RequestInfopayloads.
The firstexternalUriMappingincludes a staticauthTokenand user details. Static credentials should not be checked in. Replace these with a dynamicRequestInfotemplate or context injection.- apiRequest: {"RequestInfo": {"apiId":"org.egov.pt", ... ,"authToken":"d9994555-7656-4a67-ab3a-a952a0d4dfc8", ...}} + apiRequest: "{{ .RequestInfo | json }}"Please apply this change to all
apiRequestblocks in the file.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.externalUriMapping: - path: http://egov-location.egov:8080/egov-location/location/v11/boundarys/_search queryParam: hierarchyTypeCode=REVENUE,boundaryType=locality,codes=$.address.locality.code,tenantId=$.tenantId - apiRequest: {"RequestInfo":{"apiId":"org.egov.pt","ver":"1.0","ts":1502890899493,"action":"asd","did":"4354648646","key":"xyz","msgId":"654654","requesterId":"61","authToken":"d9994555-7656-4a67-ab3a-a952a0d4dfc8","userInfo":{"id":1,"uuid":"1fec8102-0e02-4d0a-b283-cd80d5dab067","type":"EMPLOYEE","tenantId":"pg.citya","roles":[{"name":"Employee","code":"EMPLOYEE","tenantId":"pg.citya"}]}}} + apiRequest: "{{ .RequestInfo | json }}" uriResponseMapping: - inJsonPath: $.TenantBoundary[0].boundary[0] outJsonPath: $.Data.ward - path: http://egov-workflow-v2.egov:8080/egov-workflow-v2/egov-wf/process/_search queryParam: businessIds=$.applicationNo,history=true,tenantId=$.tenantId - apiRequest: {"RequestInfo":{"apiId":"org.egov.pt","ver":"1.0","ts":1502890899493,"action":"asd","did":"4354648646","key":"xyz","msgId":"654654","requesterId":"61","authToken":"d9994555-7656-4a67-ab3a-a952a0d4dfc8","userInfo":{"id":1,"uuid":"1fec8102-0e02-4d0a-b283-cd80d5dab067","type":"EMPLOYEE","tenantId":"pg.citya","roles":[{"name":"Employee","code":"EMPLOYEE","tenantId":"pg.citya"}]}}} + apiRequest: "{{ .RequestInfo | json }}" uriResponseMapping: - inJsonPath: $.ProcessInstances outJsonPath: $.Data.history - path: http://collection-services:8080/collection-services/payments/FSM.TRIP_CHARGES/_search🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 20-20: wrong indentation: expected 9 but found 8
(indentation)
[warning] 22-22: too few spaces after comma
(commas)
[warning] 22-22: too few spaces after comma
(commas)
[warning] 22-22: too few spaces after comma
(commas)
[warning] 22-22: too few spaces after comma
(commas)
[warning] 22-22: too few spaces after comma
(commas)
[warning] 22-22: too few spaces after comma
(commas)
[warning] 22-22: too few spaces after comma
(commas)
[warning] 22-22: too few spaces after comma
(commas)
[warning] 22-22: too few spaces after comma
(commas)
[warning] 22-22: too few spaces after comma
(commas)
[warning] 22-22: too few spaces after comma
(commas)
[warning] 22-22: too few spaces after comma
(commas)
[warning] 22-22: too few spaces after comma
(commas)
[warning] 22-22: too few spaces after comma
(commas)
[warning] 22-22: too few spaces after comma
(commas)
[warning] 24-24: wrong indentation: expected 11 but found 10
(indentation)
[warning] 28-28: too few spaces after comma
(commas)
[warning] 28-28: too few spaces after comma
(commas)
[warning] 28-28: too few spaces after comma
(commas)
[warning] 28-28: too few spaces after comma
(commas)
[warning] 28-28: too few spaces after comma
(commas)
[warning] 28-28: too few spaces after comma
(commas)
[warning] 28-28: too few spaces after comma
(commas)
[warning] 28-28: too few spaces after comma
(commas)
[warning] 28-28: too few spaces after comma
(commas)
[warning] 28-28: too few spaces after comma
(commas)
[warning] 28-28: too few spaces after comma
(commas)
[warning] 28-28: too few spaces after comma
(commas)
[warning] 28-28: too few spaces after comma
(commas)
[warning] 28-28: too few spaces after comma
(commas)
[warning] 28-28: too few spaces after comma
(commas)
[warning] 30-30: wrong indentation: expected 11 but found 10
(indentation)
egov-indexer/ws-event-indexer.yml (2)
1-4:
⚠️ Potential issueFix indentation of top-level keys under ServiceMaps.
IndentserviceName,version, andmappingsby 2 spaces underServiceMaps:. Invalid indentation breaks YAML parsing.ServiceMaps: - serviceName: WS-Event indexer - version: 1.0.0 - mappings: + serviceName: WS-Event indexer + version: 1.0.0 + mappings:📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.ServiceMaps: serviceName: WS-Event indexer version: 1.0.0 mappings:
90-96:
⚠️ Potential issueParameterize
apiRequestand remove static tokens.
TheapiRequestembeds a staticauthToken—this risks exposing credentials. Replace with a dynamic placeholder or runtime injection ofRequestInfo.- apiRequest: {"RequestInfo":{...,"authToken":"02dbe5be-28df-4d82-954f-3d27c56cca7d",...}} + apiRequest: "{{ .RequestInfo | json }}"Committable suggestion skipped: line range outside the PR's diff.
🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 90-90: wrong indentation: expected 11 but found 10
(indentation)
[warning] 92-92: too few spaces after comma
(commas)
[warning] 92-92: too few spaces after comma
(commas)
[warning] 92-92: too few spaces after comma
(commas)
[warning] 92-92: too few spaces after comma
(commas)
[warning] 92-92: too few spaces after comma
(commas)
[warning] 92-92: too few spaces after comma
(commas)
[warning] 92-92: too few spaces after comma
(commas)
[warning] 92-92: too few spaces after comma
(commas)
[warning] 92-92: too few spaces after comma
(commas)
[warning] 92-92: too few spaces after comma
(commas)
[warning] 92-92: too few spaces after comma
(commas)
[warning] 92-92: too few spaces after comma
(commas)
[warning] 92-92: too few spaces after comma
(commas)
[warning] 92-92: too few spaces after comma
(commas)
[warning] 92-92: too few spaces after comma
(commas)
[warning] 94-94: wrong indentation: expected 13 but found 12
(indentation)
egov-persister/dso-persister.yaml (3)
1-103: 🛠️ Refactor suggestion
Clean up indentation and trailing spaces
YAML lint errors indicate inconsistent indentation and trailing whitespace throughout the file. Please run a YAML formatter or linter (e.g.,yamllint --fix) to correct indentation levels and remove trailing spaces, ensuring the file parses reliably.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 1-1: wrong new line character: expected \n
(new-lines)
[warning] 10-10: wrong indentation: expected 3 but found 7
(indentation)
[warning] 13-13: wrong indentation: expected 9 but found 10
(indentation)
[error] 16-16: trailing spaces
(trailing-spaces)
[error] 22-22: trailing spaces
(trailing-spaces)
[error] 26-26: trailing spaces
(trailing-spaces)
[error] 28-28: trailing spaces
(trailing-spaces)
[error] 38-38: trailing spaces
(trailing-spaces)
[error] 39-39: trailing spaces
(trailing-spaces)
[warning] 43-43: wrong indentation: expected 9 but found 10
(indentation)
[error] 84-84: trailing spaces
(trailing-spaces)
[error] 85-85: trailing spaces
(trailing-spaces)
[error] 86-86: trailing spaces
(trailing-spaces)
[warning] 92-92: wrong indentation: expected 9 but found 10
(indentation)
[error] 95-95: trailing spaces
(trailing-spaces)
[error] 96-96: trailing spaces
(trailing-spaces)
[error] 99-99: trailing spaces
(trailing-spaces)
[warning] 100-100: wrong indentation: expected 9 but found 10
(indentation)
[error] 103-103: trailing spaces
(trailing-spaces)
2-3:
⚠️ Potential issueFix serviceName typo
TheserviceNameis spelled asvendor-registory, which appears to be a typo. Rename it tovendor-registryto maintain consistency and avoid confusion.
96-103:
⚠️ Potential issueCorrect typo in vehicle insert query
The column name is misspelled asvechile_idineg_vendor_vehicle. It should bevehicle_idto match the actual schema.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 96-96: trailing spaces
(trailing-spaces)
[error] 99-99: trailing spaces
(trailing-spaces)
[warning] 100-100: wrong indentation: expected 9 but found 10
(indentation)
[error] 103-103: trailing spaces
(trailing-spaces)
egov-indexer/water-service.yml (1)
14-14: 🛠️ Refactor suggestion
Use YAML literal block for JSON mapping
Embedding large JSON directly in a single line triggers lint errors (comma-spacing) and reduces readability. Convert theindexMappingvalue to a YAML block scalar (|) to preserve formatting.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 14-14: wrong indentation: expected 9 but found 10
(indentation)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
egov-indexer/sewerage-service.yml (1)
14-14: 🛠️ Refactor suggestion
Use YAML block scalar for
indexMappingJSON
The inline JSON mapping triggers lint warnings and is hard to maintain. Converting it to a block scalar (|) will improve readability and eliminate comma-spacing errors.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 14-14: wrong indentation: expected 9 but found 10
(indentation)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
egov-persister/project-persister.yml (2)
236-258:
⚠️ Potential issueCritical: Incorrect JSON mapping for
project_targetinsert
ThejsonMapsblock duplicates theidmapping and lacks a clear mapping for theprojectIdplaceholder. The second entry should map the parent project’s ID (e.g.,$.Projects.*.id) rather than anotherid.
260-286:
⚠️ Potential issueCritical: Misaligned mappings in
project_documentinsert
- The second JSON mapping entry erroneously reuses the document
idinstead of mappingprojectId.- The
additionalDetailspath references$.Projects.*.additionalDetails(project-level) instead of the document-level path ($.Projects.*.documents.*.additionalDetails).
Please correct these to match the SQL placeholders.egov-indexer/egov-echallan.yml (3)
16-23:
⚠️ Potential issueMissing mapping for
applicationNo
TheindexMappingtemplate includesData.applicationNo, but there is nofieldMappingfor$.applicationNo. Add a mapping entry to populate this field.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 16-16: wrong indentation: expected 11 but found 10
(indentation)
71-73:
⚠️ Potential issueTypo in acknowledgementNumber path
The external URI mapping uses$.acknowldgementNumber(misspelled) forbusinessIds. It should be$.acknowledgementNumber, likely under theChallanobject (e.g.,$.Challan.acknowledgementNumber).🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 71-71: wrong indentation: expected 11 but found 10
(indentation)
[warning] 73-73: too few spaces after comma
(commas)
[warning] 73-73: too few spaces after comma
(commas)
[warning] 73-73: too few spaces after comma
(commas)
[warning] 73-73: too few spaces after comma
(commas)
[warning] 73-73: too few spaces after comma
(commas)
[warning] 73-73: too few spaces after comma
(commas)
[warning] 73-73: too few spaces after comma
(commas)
[warning] 73-73: too few spaces after comma
(commas)
[warning] 73-73: too few spaces after comma
(commas)
[warning] 73-73: too few spaces after comma
(commas)
[warning] 73-73: too few spaces after comma
(commas)
[warning] 73-73: too few spaces after comma
(commas)
[warning] 73-73: too few spaces after comma
(commas)
[warning] 73-73: too few spaces after comma
(commas)
[warning] 73-73: too few spaces after comma
(commas)
14-14: 🛠️ Refactor suggestion
Use YAML literal block for large JSON in
indexMapping
The inline JSON string triggers comma-spacing warnings and reduces readability. Switch to a YAML block scalar (|) to preserve formatting.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 14-14: wrong indentation: expected 9 but found 10
(indentation)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
egov-indexer/property-services.yml (1)
5-15:
⚠️ Potential issueFix indentation and improve readability of topic mappings.
The
- topic:and its child properties are under-indented relative tomappings:. Standardize to two spaces for list items and four spaces for nested keys.Example:
- - topic: save-property-fuzzy-data - configKey: INDEX + - topic: save-property-fuzzy-data + configKey: INDEX indexes: - name: pt-fuzzy-search-index type: generalCommittable suggestion skipped: line range outside the PR's diff.
🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 8-8: wrong indentation: expected 5 but found 6
(indentation)
[warning] 14-14: wrong indentation: expected 9 but found 10
(indentation)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
[warning] 14-14: too few spaces after comma
(commas)
egov-persister/fsm-persister.yaml (2)
336-340:
⚠️ Potential issueSQL syntax error: double comma in UPDATE statement.
The query at line 336 has
vehicle_id =?,, vehicletype—there’s an extra comma. This will break SQL execution.Apply this diff:
- UPDATE eg_fsm_application SET additionaldetails=?, ..., vehicle_id =?,, vehicletype=?, ... + UPDATE eg_fsm_application SET additionaldetails=?, ..., vehicle_id =?, vehicletype=?, ...📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.- query: UPDATE eg_fsm_application SET additionaldetails=?, applicationstatus=?, vehicle_id =?, vehicletype=?, lastmodifiedby=?, lastmodifiedtime=?, possible_srv_date=?, dso_id=? where id=? basePath: fsm jsonMaps: - jsonPath: $.fsm.additionalDetails type: JSON🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 338-338: trailing spaces
(trailing-spaces)
11-14:
⚠️ Potential issueIncorrect
basePathsyntax for JSON extraction.The
basePath: fsmshould be a JSONPath expression, e.g.,$.fsm. Otherwise, no data will be extracted.Example fix:
- basePath: fsm + basePath: $.fsm📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.basePath: $.fsm jsonMaps: - jsonPath: $.fsm.idegov-persister/sewerage-persist.yml (1)
45-52:
⚠️ Potential issueJSONPath mismatch for
oldApplicationfield.You map
$.SewerageConnection.oldApplicationbut input JSON usesoldConnectionNo. This will result in missing data.Example:
- - jsonPath: $.SewerageConnection.oldApplication + - jsonPath: $.SewerageConnection.oldConnectionNo📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.- jsonPath: $.SewerageConnection.channel - jsonPath: $.SewerageConnection.dateEffectiveFrom - jsonPath: $.SewerageConnection.additionalDetails.locality - jsonPath: $.SewerageConnection.oldConnectionNo🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 46-46: trailing spaces
(trailing-spaces)
[HCMPRE-2648] - HCM Campaign Provincial Dashboard - Overview Page
[HCMPRE-2650] - HCM Campaign Provincial Dashboard - Inventory Page
…' into HCMPRE-2649
[HCMPRE-2649] - HCM Campaign Provincial Dashboard -Registration and d…
[HCMPRE-2672] - HCM Campaign Provincial Dashboard - Referral Page
[HCMPRE-2645] added kibana map chart config for administration successful
added kibana map chart config for administration unsuccessful
added kibana map chart config for checklists filled
# Conflicts: # egov-dss-dashboards/dashboard-analytics/ChartApiConfig.json # egov-dss-dashboards/dashboard-analytics/MasterDashboardConfig.json
Summary by CodeRabbit