Add test suite and GitHub Actions CI - #11
Merged
Merged
Conversation
- test/CMakeLists.txt: configure-time test that runs find_package(FFTW) and checks FFTW_FOUND, FFTW_INCLUDE_DIRS, FFTW_LIBRARIES, per-component _FOUND/_LIB variables, and imported CMake targets - .github/workflows/test.yml: three-way matrix (apt, source tarball, conda-forge) apt: tests 9 components (3 precisions × basic/threads/openmp) source: builds FFTW 3.3.10 from tarball with cache, tests all 9 variants conda: installs fftw from conda-forge via micromamba, tests 6 variants
Copilot
AI
changed the title
[WIP] Add test suite and CI for FindFFTW
Add test suite and GitHub Actions CI
Jun 16, 2026
There was no reuse across the matrix, all steps were conditional on one of the matrix elements!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No automated tests existed for
FindFFTW.cmake, making it hard to validate changes or catch regressions. Adds a configure-time CMake test and a 3-job GitHub Actions matrix covering the main FFTW install scenarios.test/CMakeLists.txtConfigure-time test project (
project(... NONE)— no compiler needed). Accepts a semicolon-separated component list via-DFFTW_TEST_COMPONENTSand asserts:FFTW_FOUND,FFTW_INCLUDE_DIRS,FFTW_LIBRARIESare setFFTW_<component>_FOUND,FFTW_<component>(library path), and imported CMake target (FFTW::Double, etc.) are setRun manually as:
.github/workflows/test.ymlThree-job matrix on
ubuntu-latest,fail-fast: false:aptlibfftw3-devsource--enable-threads --enable-openmp× 3 precisions; result cachedFFTW_ROOTcondaconda-forge::fftwvia micromambaFFTW_ROOT=$CONDA_PREFIX