Skip to content

Format cmake file with cmake-format default settings - #12

Closed
zhao-shihan wants to merge 1 commit into
egpbos:masterfrom
zhao-shihan:master
Closed

Format cmake file with cmake-format default settings#12
zhao-shihan wants to merge 1 commit into
egpbos:masterfrom
zhao-shihan:master

Conversation

@zhao-shihan

Copy link
Copy Markdown
Contributor

Simply format code with default cmake-format (also added some necessary ~~~ fence to annotations).

The default config uses 2-space indent and 80-char max width so they look quite different as before.

Follow up #10 (comment) .

@egpbos

egpbos commented Jun 19, 2026

Copy link
Copy Markdown
Owner

Thanks for trying this out! I'm afraid I'm not convinced of this change, though. The consistent standard 2-spacing is nice, but some changes I don't really like (e.g. the FFTW::* definitions that were nicely aligned and now actually look more messy, also some parameters that were logically separated across lines that now get bunched into one line, like for _all_components, and some more examples). If this is easily configurable, I'd be willing to have another look, but if not, let's drop this. By the way, unless I'm mistaken, it seems that cmake-format has not been maintained for 5 years. I don't think it would be wise to depend on it then.

@zhao-shihan

Copy link
Copy Markdown
Contributor Author

If this is easily configurable, I'd be willing to have another look, but if not, let's drop this.

Yes, I don't think it is very easy to configure that. That's why I just simply tried the default one.

it seems that cmake-format has not been maintained for 5 years

That's true.

So let's just forget about this. I'll close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants