You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for trying this out! I'm afraid I'm not convinced of this change, though. The consistent standard 2-spacing is nice, but some changes I don't really like (e.g. the FFTW::* definitions that were nicely aligned and now actually look more messy, also some parameters that were logically separated across lines that now get bunched into one line, like for _all_components, and some more examples). If this is easily configurable, I'd be willing to have another look, but if not, let's drop this. By the way, unless I'm mistaken, it seems that cmake-format has not been maintained for 5 years. I don't think it would be wise to depend on it then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply format code with default cmake-format (also added some necessary
~~~fence to annotations).The default config uses 2-space indent and 80-char max width so they look quite different as before.
Follow up #10 (comment) .