Set grace period to 10 seconds for nfsv4#44
Open
phlax wants to merge 1 commit intoehough:developfrom
Open
Conversation
Owner
|
This looks great! Thank you for the contribution! Let me do a quick round of testing on my end and then I'll merge.
I also am not sure why. I peeked at the source for nfsd and confirmed it uses seconds for the unit. |
Open
|
Hi, as I'm facing issue #48 as well, I stumbled upon this PR. Is there any objection to merging it? I'm also affected by the 90-second grace period, not sure why it's there, but it makes my NFS server unusable for 90s after container startup. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the default
grace-periodto 10 seconds.Fixes #22
Not sure if this should be configurable or where best to put the flag.
In my limited testing this speeds up initial file access on an
nfsv4mount from~100sto<1sNot sure why the grace period is set so long by default
Im also unclear as to why setting
10for the grace period cuts the time to under a second - the man page seems to suggest that the grace-period is measured in seconds:https://manpages.debian.org/stretch/nfs-kernel-server/nfsd.8.en.html