Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Backports the Acts “Gen3 DD4hep construction” change into the Acts v45 Spack package by applying the upstream patch from acts-project/acts#5193.
Changes:
- Add a new Spack
patch()entry to apply the Gen3 DD4hep construction backport for Acts versions@45.2:46.2.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wdconinc
added a commit
that referenced
this pull request
Apr 18, 2026
Spack switched to ruff for style checks. This adds a minimal `pyproject.toml` to configure ruff so that CI style checks pass. The key fix is the `per-file-ignores` section that suppresses `F403`, `F405`, `F811`, and `F821` for package files, which use `from spack.package import *` (star imports are expected in Spack packages). Fixes the CI failure in #887. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
veprbl
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
This PR backports the Acts Gen3 DD4hep construction acts-project/acts#5193 into acts v45 so we can roll this out in development sooner.
Tested that this cherry-picks cleanly into 45.2.0, and that it is included in release 46.3.0. Checked with AI that there are no hidden dependencies that would affect functionality outside of cherry-pick merge conflicts.
What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply