fix: stop task not working as expected #713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve merge conflicts in src/store/chatStore.ts by combining: - Connection retry logic for SSE errors from main branch - Cleanup logic for AbortController from pause_task_fix branch 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
a7m-1st
reviewed
Nov 20, 2025
Comment on lines
1668
to
1679
| onerror(err) { | ||
| console.error("Error:", err); | ||
| console.error("SSE Error:", err); | ||
| // Clean up AbortController on error | ||
| try { | ||
| if (activeSSEControllers[newTaskId]) { | ||
| delete activeSSEControllers[newTaskId]; | ||
| } | ||
| } catch (error) { | ||
| console.warn('Error cleaning up AbortController on SSE error:', error); | ||
| } | ||
| throw err; | ||
| }, |
Collaborator
There was a problem hiding this comment.
Are we targetting for skip to behave like stop? @Wendong-Fan
🤔 If so I think we can re-implement the new on "error" message logic on #663.
Comment on lines
+424
to
-432
|
|
||
| try { | ||
| // Skip the current task | ||
| // First, try to notify backend to skip the task | ||
| await fetchPost(`/chat/${projectStore.activeProjectId}/skip-task`, { | ||
| project_id: projectStore.activeProjectId | ||
| }); | ||
|
|
||
| // Update task status to finished | ||
| chatStore.setStatus(taskId, 'finished'); | ||
| // Only stop local task if backend call succeeds | ||
| chatStore.stopTask(taskId); | ||
| chatStore.setIsPending(taskId, false); | ||
|
|
||
| // toast.success("Task skipped successfully", { | ||
| // closeButton: true, | ||
| // }); |
Collaborator
There was a problem hiding this comment.
@Wendong-Fan in this PR #735, it just makes the skip task == stop task.
- Replay proof, where the skip task can be replicated with the replay api.
- But maybe can borrow your idea of activeSSEControllers as it still suffers from ghost SSEs (i.e. Post stop)
Wendong-Fan
added a commit
that referenced
this pull request
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the purpose of this pull request?