remove create > invalid user settable id > too short test because min allowed is 1 #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yoshiji
changed the title
|
Nice catch @Yoshiji! ⭐ LGTM We follow conventional commits in this repository, so you'll have to update the commit message. |
…because min allowed is 1 The generated test Create/invalid_user_settable_id/too_short is asserting the create call fails with a value of "foo" (3 runes), but AIP states the minimum length allowed is 1. Source: https://google.aip.dev/122#resource-id-segments
Yoshiji
force-pushed
the
remove-create-with-user-settable-id-too-short-test
branch
from
9c4ad3f to
7fb49c9
Compare
|
@ericwenn I reworded the commit message. |
ericwenn
approved these changes
Nov 26, 2024
Yoshiji
deleted the
remove-create-with-user-settable-id-too-short-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: The
Create/invalid_user_settable_id/too_shortgenerated test is not following AIP-122 because single-letter ID is valid.https://google.aip.dev/122#resource-id-segments mentions the regex to validate the user-provided ID:
Which follows RFC-1034 rule for labels. Quoting https://www.rfc-editor.org/rfc/rfc1034 (ctrl+f "ARPANET host names")
A valid label can be a single letter. The generated test
too shortfor user settable ID is not feasible because trying to test with an ID with a length equal to 0 = empty = the server will fall back to system-generated ID:Source: https://google.aip.dev/133#user-specified-ids