feat(sgapilinter): bump and revert #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kristofferwanglund the bug was fixed and we can revert your change. Maybe you can give this a try before merging, but I have verified it works on my end (in my editor). |
fredrikaverpil
force-pushed
the
bump-api-linter-revert
branch
from
0232d4d to
adf52af
Compare
alethenorio
approved these changes
Feb 20, 2025
This change does not longer require --proto-path=. to be set
This reverts commit a5cc0d9.
fredrikaverpil
force-pushed
the
bump-api-linter-revert
branch
from
adf52af to
234ed99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
With api-linter v1.69.1, there was a side-effect/bug introduced which required us to add
--proto-path=.to keep api-linter working. This side-effect/bug was fixed in v1.69.2.We can keep
--proto-path=.or remove it (hence the two separate commits) without issues, but I figured we should remove it.What?
Notes