Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sgapilinter): bump and revert #644

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Conversation

fredrikaverpil
Copy link
Member

@fredrikaverpil fredrikaverpil commented Feb 20, 2025

Why?

With api-linter v1.69.1, there was a side-effect/bug introduced which required us to add --proto-path=. to keep api-linter working. This side-effect/bug was fixed in v1.69.2.

We can keep --proto-path=. or remove it (hence the two separate commits) without issues, but I figured we should remove it.

What?

  • feat(sgapilinter): bump with bugfix
  • fix(sgapilinter): revert "include proto path"

Notes

@fredrikaverpil fredrikaverpil requested review from a team as code owners February 20, 2025 20:04
@fredrikaverpil fredrikaverpil self-assigned this Feb 20, 2025
@fredrikaverpil
Copy link
Member Author

fredrikaverpil commented Feb 20, 2025

@kristofferwanglund the bug was fixed and we can revert your change. Maybe you can give this a try before merging, but I have verified it works on my end (in my editor).

This change does not longer require --proto-path=. to be set
@fredrikaverpil fredrikaverpil enabled auto-merge (rebase) February 21, 2025 09:24
@fredrikaverpil fredrikaverpil merged commit 00d9ea5 into master Feb 21, 2025
2 checks passed
@fredrikaverpil fredrikaverpil deleted the bump-api-linter-revert branch February 21, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants