Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Go 1.17 in CI #647

Closed
wants to merge 2 commits into from
Closed

Use Go 1.17 in CI #647

wants to merge 2 commits into from

Conversation

fredrikaverpil
Copy link
Member

@fredrikaverpil fredrikaverpil commented Feb 28, 2025

Why?

If I'm not mistaken, the idea is that Sage should be compatible with Go projects
written with Go 1.17, given the contents of the go.mod file:

https://github.com/einride/sage/blob/master/go.mod#L3

However, there is code in the repo which requires newer Go versions.

What?

  • Use Go v1.17 in CI, so to surface the warnings/errors which needs fixing.
  • Do not use errors.Join (introduced in Go 1.20)
  • Do not use math/rand/v2 (introduced in Go 1.22)
  • ...

Notes

@fredrikaverpil fredrikaverpil self-assigned this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant