Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(spanner): bump to latest and regenerate golden test files #554

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

fredrikaverpil
Copy link
Member

@fredrikaverpil fredrikaverpil commented Feb 19, 2025

Why?

Spanner v1.72.0 requires us to regenerate/update some golden test files.

[go-test] --- FAIL: TestDatabaseDescriptorCodeGenerator_GenerateCode (0.00s)
[go-test]     --- FAIL: TestDatabaseDescriptorCodeGenerator_GenerateCode/database/testdata/2.sql (0.05s)
[go-test]         goldenfile_test.go:42: assertion failed: 
[go-test]             --- expected
[go-test]             +++ actual
[go-test]             @@ -18,5 +18,5 @@
[go-test]              		singerId: columnDescriptor{
[go-test]              			columnID:             "SingerId",
[go-test]             -			columnType:           spansql.Type{Array: false, Base: 1, Len: 0},
[go-test]             +			columnType:           spansql.Type{Array: false, Base: 1, Len: 0, ProtoRef: ""},
[go-test]              			notNull:              true,
[go-test]              			allowCommitTimestamp: false,

...

What?

I ran this and closed my eyes
$ go get cloud.google.com/go/spanner@latest                 
go: downloading cloud.google.com/go v0.118.2
go: downloading cloud.google.com/go/spanner v1.75.0
go: downloading github.com/golang/mock v1.7.0-rc.1
go: upgraded cloud.google.com/go v0.116.0 => v0.118.1
go: upgraded cloud.google.com/go/iam v1.3.0 => v1.3.1
go: upgraded cloud.google.com/go/longrunning v0.6.3 => v0.6.4
go: upgraded cloud.google.com/go/monitoring v1.22.0 => v1.23.0
go: upgraded cloud.google.com/go/spanner v1.70.0 => v1.75.0
go: upgraded github.com/GoogleCloudPlatform/grpc-gcp-go/grpcgcp v1.5.0 => v1.5.2
go: upgraded go.opentelemetry.io/otel/sdk v1.33.0 => v1.34.0
go: upgraded google.golang.org/genproto v0.0.0-20241015192408-796eee8c2d53 => v0.0.0-20250122153221-138b5a5a4fd4
$ make spanner-generate

...
$ go test ./internal/codegen/... -update -tags=testdata.1.sql.database -tags=testdata2.sql.database -tags=testdata3.sql.database

?       go.einride.tech/spanner-aip/internal/codegen    [no test files]
ok      go.einride.tech/spanner-aip/internal/codegen/databasecodegen    1.710s
ok      go.einride.tech/spanner-aip/internal/codegen/descriptorcodegen  0.987s
?       go.einride.tech/spanner-aip/internal/codegen/typescodegen       [no test files]
$ git status

On branch bump-spanner
Your branch is up to date with 'origin/bump-spanner'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   internal/codegen/descriptorcodegen/testdata/1.sql.database.go
        modified:   internal/codegen/descriptorcodegen/testdata/2.sql.database.go
        modified:   internal/codegen/descriptorcodegen/testdata/3.sql.database.go

no changes added to commit (use "git add" and/or "git commit -a")

Notes

@fredrikaverpil fredrikaverpil self-assigned this Feb 19, 2025
@fredrikaverpil fredrikaverpil marked this pull request as ready for review February 19, 2025 12:22
@fredrikaverpil fredrikaverpil requested review from odsod, thall and a team as code owners February 19, 2025 12:22
@fredrikaverpil fredrikaverpil changed the title chore(spanner): bump to latest v1.75.0 chore(spanner): bump to latest v1.75.0 and regenerate golden test files Feb 19, 2025
@fredrikaverpil fredrikaverpil changed the title chore(spanner): bump to latest v1.75.0 and regenerate golden test files chore(spanner): bump to latest and regenerate golden test files Feb 19, 2025
@fredrikaverpil fredrikaverpil merged commit 71a2334 into master Feb 19, 2025
1 check passed
@fredrikaverpil fredrikaverpil deleted the bump-spanner branch February 19, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants