Use cached reflection invokers in no-emit accessors - #479
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2bac0ef2-0b37-41bc-991c-9d7181fb1e21
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2bac0ef2-0b37-41bc-991c-9d7181fb1e21
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2bac0ef2-0b37-41bc-991c-9d7181fb1e21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the
MethodInvokerandConstructorInvokerpattern from dotnet/runtime#131018 to PolyType's no-emit reflection member accessor on .NET 8 and later. Invokers are cached when accessors are created for methods, constructors, events, collection factories and appenders, nested tuple getters, member initializers, and F# functions.net472andnetstandard2.0retain the existing reflection fallback.Ordinary property getters and setters already use typed delegates and remain unchanged. Value-type targets continue to be boxed and copied back where mutation is observable.
MethodInvokeBenchmarks.MethodShapeReflectionon .NET 10 improved from 142.7 ns to 131.1 ns for six arguments (about 8%); allocations remained at 272 B.make testpassed with 289,687 CLR tests and 29 Native AOT tests.