j.l.Class: include componentType() in isArray() @EnsureNonNullIf annotation#128
Open
thisisalexandercook wants to merge 1 commit intoeisop:masterfrom
Open
j.l.Class: include componentType() in isArray() @EnsureNonNullIf annotation#128thisisalexandercook wants to merge 1 commit intoeisop:masterfrom
j.l.Class: include componentType() in isArray() @EnsureNonNullIf annotation#128thisisalexandercook wants to merge 1 commit intoeisop:masterfrom
Conversation
j.l.Class: include componentType() in isArray() @EnsureNonNullIf` annotation
j.l.Class: include componentType() in isArray() @EnsureNonNullIf` annotationj.l.Class: include componentType() in isArray() @EnsureNonNullIf annotation
Member
|
One thing to test: componentType() was added in JDK 12. In general, we probably want warnings about contracts that refer to methods that don't exist. But for the JDK we need some special handling. So we just need to make sure whether we get a warning on the use of a method that uses a non-existing method in a contract. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
componentType()method to the@EnsureNonNullannotation expression list attached to theisArray()method.componentType()is indicated as equivalent togetComponentType()which is already included in this expression list.