Exclude CLAUDE.md and docs/ from packaged gem files - #48
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates gem packaging so non-distributable project files (notably CLAUDE.md and docs/**) are not included in the built gem, addressing downstream packaging issues reported in #46.
Changes:
- Tighten
spec.filesinnet-ping.gemspecto excludeCLAUDE.mdanddocs/**. - Add a packaging-focused regression test ensuring those paths are absent from
spec.files. - Add a new design note under
docs/superpowers/specs/.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
net-ping.gemspec |
Excludes CLAUDE.md and docs/** from spec.files to prevent shipping them in the gem. |
test/test_net_ping_gem_packaging.rb |
Adds a regression test asserting non-distributable paths are not present in spec.files. |
docs/superpowers/specs/2026-08-08-pr-25-http-query-design.md |
Adds an internal design document (appears unrelated to this PR’s stated scope). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
spec.files globbed every file on disk, so AI-assistant instructions and session notes ended up shipped inside net-ping-2.1.0, breaking downstream RPM packaging (issue #46). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
eitoball
force-pushed
the
fix-46-exclude-claude-md-from-gem
branch
from
August 16, 2026 08:43
6291b25 to
da11a30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spec.filesglobbed every file on disk (Dir['**/*']), so AI-assistant instructions (CLAUDE.md) and session notes (docs/superpowers/**) ended up shipped inside thenet-ping-2.1.0gem, breaking downstream RPM packaging.CLAUDE.mdand everything underdocs/fromspec.files. The two platform gemspecs (net-ping-universal-*.gemspec)dupthis spec, so they inherit the fix automatically.Fixes #46
Test plan
test_gem_create_excludes_non_distributable_project_files_from_spec_files, watched it fail against the oldspec.files(listedCLAUDE.mdand alldocs/superpowers/**entries), then confirmed it passes after the fix.bundle exec rake test— 110 tests, 0 failures.