fix: preserve partial column lineage diagnostics - #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
column_indeterminatediagnostics instead of fatalcolumn_not_founderrorsBehavior
For BigQuery row-value patterns such as
ARRAY_AGG(t ...)[OFFSET(0)] AS eventfollowed byevent.field:event.fieldsource with no diagnosticcolumn_not_foundand exited 1column_indeterminatewith the root output column, and exits 0 when no fatal diagnostics remainDiagnostics from excluded outputs and unrelated same-named upstream branches are suppressed. Missing requested columns, ambiguous columns, parse failures, and internal failures remain fatal.
Performance
The release-candidate correctness path retried the full upstream SQL once per indeterminate field. Because the SQL also grows with the number of expanded fields, downstream analysis scaled quadratically.
Linux x86_64 dist builds,
--no-cache, hyperfine warmup 1 / 5 runs:The before and after builds produce identical stdout, stderr, and exit status for all three fixtures. The existing on-demand recovery remains enabled when the all-column analysis did not produce a matching scoped diagnostic.
Validation
cargo test --workspace --lockedcargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-features --locked -- -D warningscargo build --profile dist --locked