chore: fix cargo fmt and flaky test race - #2
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Tests that mutate the global ERROR_FORMAT / QUIET flags can race when run in parallel, producing flaky failures (observed on macOS CI). Add serial_test and mark those tests #[serial] so they run sequentially. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
eitsupi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo fmtviolations insrc/lib.rsfrom the structured error diagnostics commitserial_testto prevent test race on globalERROR_FORMAT/QUIETstate (flaky failure observed on macOS CI)Test plan
cargo fmt --checkpassescargo testpasses locally🤖 Generated with Claude Code