Fix importing problem #111
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See eivindfjeldstad#101 for the error and a description of why it occurs. Basicly TS expects the module to have a `default` export when compiling down from ES6 to CommonJS. `add-module-exports` does not set it by default, causing the error. This patch will just add the needed export. @eivindfjeldstad
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
==========================================
- Coverage 98.79% 98.38% -0.41%
==========================================
Files 6 6
Lines 248 248
==========================================
- Hits 245 244 -1
- Misses 3 4 +1
Continue to review full report at Codecov.
|
Switched from `prepublish` to `prepare` in order to make installs directly from git possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #101 for the error and a description of why it occurs. Basicly TS expects the module to have a
defaultexport when compiling down from ES6 to CommonJS.add-module-exportsdoes not set it by default, causing the error. This patch will just add the needed export.@eivindfjeldstad