Remove global interval.__ref__ to avoid race #132
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@redbaron Thank you. Good catch. I'll try to include this in the next 0.4.5 release. |
redbaron
force-pushed
the
fix-changes-blame-race
branch
from
2af7bb1 to
66a18ad
Compare
If submodule used to be in history but since then was deleted, `git show <commit>:submodule_path` would produce `bad object` error as no info about given submodule can be found in HEAD.
redbaron
force-pushed
the
fix-changes-blame-race
branch
from
66a18ad to
5361175
Compare
|
Also piggyback change to skip submodules |
adam-waldenberg
added a commit
that referenced
this pull request
May 13, 2017
Previoulsy, we were just checking against the changes returned from the last repository analyzed - which of course broke the whole thing if that repository had no matching commits!
adam-waldenberg
added a commit
that referenced
this pull request
May 13, 2017
If the changeset was empty or filtered with no matching files a bunch of errors would be thrown from git with no proper results being returned back to gitinspector. We now pipe stderr (catching the output) and also check the return code when running these commands.
|
@redbaron This should be fixed. I decided to handle it slightly differently and with the same changes also fix a different issue happening when analyzing multiple repos, as seen in #115. When it comes to submodules - I don't think we should skip them altogether. It's probably better to handle the fact that they have been removed. Maybe a new pull request handling this would be an idea. If you are up for it. People use submodules to merge statistics from multiple repos sometimes. Let me know if any issues still persist related to ref. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously it was broken when multiple repos where exemined and '--since' was used: global
interval.__ref__was set to a commit ID valid for only one last examined repo, making it fail for all others