Skip to content

Relative imports to fix packaging issues #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2015

Conversation

marcharper
Copy link
Contributor

Re: #73. Tested with Python 2.7.9 and 3.4.3.

@marcharper
Copy link
Contributor Author

Should be good to go -- I tried to change as few lines as possible.

@adam-waldenberg
Copy link
Member

Hi. Great! Thank you for taking the time to look into this.

I actually managed to "fix" this yesterday... But my solution was to change to absolute imports and moving gitinspector.py one level back.

This was the only way for me to get it to work without either breaking egg installations or being able to execute the script "locally"... It has to be said, I don't really like moving gitinspector.py to the root directory.

I'll look at your pull request tonight... It's probably be the better solution.

@marcharper
Copy link
Contributor Author

This should work locally and doesn't require moving gitinspector.py. I tested actually installing and it works fine that way as well. Let me know if you have any questions or issues!

@adam-waldenberg adam-waldenberg merged commit 59d9e5c into ejwa:master Oct 21, 2015
@adam-waldenberg adam-waldenberg added this to the 0.4.3 milestone Oct 21, 2015
@adam-waldenberg
Copy link
Member

Merged. After adding a new entry script to the root, this works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants