Update Pynq Driver #100
Merged
Update Pynq Driver #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add RFSoC4x2 PAF support
This comment was marked as resolved.
This comment was marked as resolved.
Add missing qonnx files
Extended tests
Updated driver.py to reflect changes in driver_base.py
Fix pytest errors/failures
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
33 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Fix bugs in experiment_manager
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
fpjentzsch
reviewed
Nov 4, 2025
fpjentzsch
reviewed
Nov 4, 2025
fpjentzsch
reviewed
Nov 4, 2025
fpjentzsch
reviewed
Nov 4, 2025
fpjentzsch
reviewed
Nov 4, 2025
fpjentzsch
reviewed
Nov 4, 2025
fpjentzsch
reviewed
Nov 5, 2025
fpjentzsch
reviewed
Nov 5, 2025
fpjentzsch
reviewed
Nov 5, 2025
fpjentzsch
reviewed
Nov 5, 2025
| return settings | ||
|
|
||
| def apply(self, model): | ||
| # TODO: support runtime-writable and external weights (instr) |
There was a problem hiding this comment.
For clarification: Since driver/make_driver are now unified, doesn't that mean we now support runtime-writable and external weights when instrumentation is enabled (at least when instrumentation_no_dma is false and we use the FINNDMAInstrumentationOverlay, which inherits from FINNDMAOverlay that handles these features)?
fpjentzsch
reviewed
Nov 5, 2025
fpjentzsch
reviewed
Nov 5, 2025
Fix project generation Add Docs
This comment was marked as resolved.
This comment was marked as resolved.
fpjentzsch
reviewed
Dec 5, 2025
Fix CLI bool conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
For an example look at the driver_rework_test.yml. It generated a config based on the experiment_config selected and driver_config generated during the make_driver step.