Skip to content

Fix outdated string based path concatenation in verify_step#202

Open
iksnagreb wants to merge 3 commits into
devfrom
fix/verify-step-paths
Open

Fix outdated string based path concatenation in verify_step#202
iksnagreb wants to merge 3 commits into
devfrom
fix/verify-step-paths

Conversation

@iksnagreb
Copy link
Copy Markdown

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

📋 Docstring Check Report

Docstring check failed!

Missing Docstrings Details:

📄 src/finn/builder/build_dataflow_steps.py:

  • Line 368: function 'prepare_loop_ops_fifo_sizing'
  • Line 403: function 'prepare_loop_ops_ipgen'
  • Line 508: function 'apply_if_relevant'
  • Line 1228: function 'verify_mlo'

Total missing docstrings: 4

How to Fix:

Please add docstrings to the missing functions, classes, and modules listed above.

Docstring Guidelines:

  • All modules should have a module-level docstring
  • All public functions and methods should have docstrings
  • All private functions should have docstrings
  • All classes should have docstrings
  • Use triple quotes (""") for docstrings
  • Follow PEP 257 conventions
Raw output from docstring checker
Checking 1 specified Python file(s) (excluding tests folder):
  - src/finn/builder/build_dataflow_steps.py

❌ Missing docstrings found:

📄 src/finn/builder/build_dataflow_steps.py:
  - Line 368: function 'prepare_loop_ops_fifo_sizing'
  - Line 403: function 'prepare_loop_ops_ipgen'
  - Line 508: function 'apply_if_relevant'
  - Line 1228: function 'verify_mlo'

Total missing docstrings: 4

@bwintermann
Copy link
Copy Markdown

Could fail because output_dir is str | Path. For now I'd either wrap everything in Path(...) or remove the str type.

@bwintermann bwintermann added this to the FINN+ v1.5.0 milestone Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants