[Folding] Fixed AP_INT_MAX_W error and added throughput folding warnings #209
Open
bwintermann wants to merge 2 commits into
Open
[Folding] Fixed AP_INT_MAX_W error and added throughput folding warnings #209bwintermann wants to merge 2 commits into
bwintermann wants to merge 2 commits into
Conversation
…or the max value of AP_INT_MAX_W
fpjentzsch
requested changes
May 11, 2026
…u_wwidth_max. Changed warning texts.
Author
|
@fpjentzsch I fixed the issue and reworded some of the warnings. I also added a check that warns the user if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, folding could create weight streams wider than configured in
mvau_wwidth_max, since only SIMD, not PE was checked during folding. However for theMVAU_hlsininternal_decoupledmode, the instream width is defined assimd*pe*bitwidth, so an unbounded PE value could cause the stream width to overshoot the limit.Additionally, the
MVAU_hlsimplementation failed to correctly verify that theAP_INT_MAX_Wvalue was below the upper limit of 8191. The default and max value of this macro can be looked up in UG1399. This is now fixed and theHLSBackendandMVAU_hlscheck against a constant defined infinn.utils.basic.Finally, in case that a node cannot reach the expected throughput (cycles per frame), a warning is printed.