[Deps] Add "pyyaml==6.0.1" dependency to Dockerfile #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-part-map Add V80 to Alveo part_map
|
This seems to crash with the changes that you did with the |
Author
|
Oh, no, you should not have merged our dev here, this is a mirror of the upstream PR, you now extended my existing PR to Xilinx/dev to also include our dev... This one should have actually just been a single line to Dockerfile (+ the recent upstream dev, which we would have synchronized anyway soon...). Was there actually a conflict you tried to resolve by merging dev? |
|
Oh damn sorry overlooked this. No I just wanted to sync the part_map line which I mistakenly thought would already be in our dev too but didn't see it was from your own repo. |
iksnagreb
force-pushed
the
deps/pyyaml
branch
from
7ab0dcb to
6d691a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More of a personal preference, but I assume I am not alone. I like to specify my model or "experiment" configurations as well as the metrics collected in YAML format instead of JSON, see here for an example: https://github.com/iksnagreb/attention-dummy/blob/benchmark/params.yaml
I think it does not hurt to add a YAML parser into the finn container, at least it should not interfere with anything else and I do not expect frequent changes to this dependency either.
See Xilinx#966