[INCOMPLETE!] Getting non-public static property#27
Open
tpluscode wants to merge 2 commits intoekonbenefits:masterfrom
Open
[INCOMPLETE!] Getting non-public static property#27tpluscode wants to merge 2 commits intoekonbenefits:masterfrom
tpluscode wants to merge 2 commits intoekonbenefits:masterfrom
Conversation
tpluscode
commented
Sep 9, 2018
| catch (RuntimeBinderException) | ||
| { | ||
|
|
||
| } |
Author
There was a problem hiding this comment.
Removing this try..catch causes all test cases to fail but I do not understand why
tpluscode
commented
Sep 9, 2018
|
|
||
| tBinderType = typeof (InvokeMemberBinder); | ||
| tKnownType = KnownMember; | ||
| } |
Author
There was a problem hiding this comment.
This binder only works for public type. The else only works for private type when a property is set-first...
Member
|
This is really interesting... I'm on paternity leave right now, but I'll hopefully soon get a chance to look at this too. |
Author
|
Have you had a chance to look at this @jbtule? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR kind of fixes #26
It demonstrates what I attempted to fix
InvokeGetof private static properties (or public property of a non-public type).