fix: remove leftover suite-orig.robot from web-carinsurance - #20
Merged
Conversation
examples/web-carinsurance shipped both suite.robot and suite-orig.robot. Robot Framework's `robot .` (used by both CI and every os/<slug> container) auto-discovers every .robot file in the target directory as its own suite, so suite-orig.robot always ran alongside suite.robot. suite-orig.robot is the pre-refactor original, hardcoding `New Browser headless=false` instead of honoring ROBOTMK_HEADLESS_HOST like suite.robot's BrowserCommon.resource does. In any environment without a desktop (bare CI runners, os/* provisioning containers, headless devcontainers), that hardcoded headless=false tries to open a real browser window with no display to render to, and fails. Removing it — suite.robot already covers the same test case correctly. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/web-carinsuranceshipped bothsuite.robotand a leftoversuite-orig.robot(the pre-refactor original).robot .(used by CI'stestjob and everyos/<slug>provisioning container) auto-discovers every.robotfile in the target directory as its own suite, sosuite-orig.robotalways ran too, alongsidesuite.robot.suite-orig.robothardcodesNew Browser ... headless=false, ignoringROBOTMK_HEADLESS_HOST(unlikesuite.robot, which goes throughResources/BrowserCommon.resource's env-var-awareBrowser Initkeyword). In any desktop-less environment this tries to open a real browser window with no display, and fails.suite-orig.robotfrom both the generated output and its Copier source (_dev/_examples/web-carinsurance/template/).Test plan
examples/web-carinsurancevia_dev/scripts/generate-all.sh web-carinsurance— confirmed onlysuite.robotis produced now.robot --dryrun .inexamples/web-carinsurancebefore and after: before, RF discovered two suites (Web-Carinsurance.SuiteandWeb-Carinsurance.Suite-Orig); after, only one (Web-Carinsurance.Suite).🤖 Generated with Claude Code