Add "My series" page #1311

owi92 · 2025-01-09T13:55:51Z

This adds a page to the "manage pages" area were users can see a list of their series.
Most of these changes are related to generalizing the "My videos" backend and frontend code, so it can also be used for series-, and later on playlist management.

This PR also addresses two issues related to the "My videos" table.

Please note that this is only the first step in adding a proper series management in Tobira. Right now, the list entries link directly to the corresponding series. This will be changed later to link to a "Series details" page.

Note for the reviewer: This is probably better to review file-by-file, since a lot of the commits touch and revise the same files.

Part of #355
Fixes #759
Closes #527

I didn't like the name.

It did not need to be so complicated.

LukasKalbertodt

This is just a review of the backend code. And while I left quite a lot of inline comments, I am actually very happy with that! The approach is sane and you used Rust features cleverly, even wrote a macro! Most of my comments just refer to minor things one can write in a shorter way.

backend/src/api/model/event.rs

backend/src/api/model/shared.rs

backend/src/api/model/user.rs

backend/src/api/model/series.rs

LukasKalbertodt

Ok, here is a review of the frontend. I didn't test it in detail yet, but from what I saw, I like it. Looks good.

frontend/src/routes/Search.tsx

frontend/src/routes/manage/Series/index.tsx

backend/src/api/model/shared.rs

frontend/src/routes/manage/Series/index.tsx

frontend/src/routes/manage/shared.tsx

frontend/src/routes/manage/Series/index.tsx

LukasKalbertodt

Reviewed all changes again, much improved. Still some comments but nothing complicated I think.

backend/src/api/model/series.rs

backend/src/api/model/shared.rs

backend/src/db/migrations/41-series-index.sql

frontend/src/routes/manage/Series/index.tsx

frontend/src/routes/manage/shared.tsx

Just some refactoring, but which slightly changes the API in an insignificant way.

I change the `myFoo` functions in a way to allow the `mySeries` one to fetch the thumbnail info already. This results in two new API fields that is used by the "my series" page to gather all necessary info without causing an 1+n query problem.

Solve 1+n query problem

@Reviewer

Step 2 in adding proper series management. Adds series details and acl pages, making sure all new and/or refactored components can also be used for playlists later on. Resolves #1366 Based on #1311 Step 3 will then be more API related stuff, adding creation and content editing. Edit: I added metadata editing here, and plan on also adding the delete function in this pull request. So, todos for this PR: - [x] add delete function and UI (there are still some things to adjust) - [x] investigate deserialization error (could not reproduce anymore) - [x] fix translation/i18n - [x] disable acl editing when series is not synced yet - [x] list host realms - [x] properly rebase this onto #1311 again, but that is pending a review anyway so I'll do that last - [x] ~~**This is currently broken**~~ Need to fix `'unwrapped an unloaded LazyLoad'` error with series thumbnail on details page.* - [ ] * I fixed the above, but maybe we shoud make sure that each place that needs a series thumbnail uses the same event order for it. - [x] Fix series deletion. I already did, but messed up and lost the fixed version during my rebase. @Reviewer (is that a real user??): Once again, this is unfortunately probably better to review file-by-file, though it might still be useful to read the commit messages.

owi92 added the changelog:user User facing changes label Jan 9, 2025

github-actions bot temporarily deployed to test-deployment-pr1311 January 9, 2025 14:04 Destroyed

owi92 force-pushed the series-management branch from 0d8826c to 7b97115 Compare January 10, 2025 14:58

github-actions bot temporarily deployed to test-deployment-pr1311 January 10, 2025 15:03 Destroyed

github-actions bot temporarily deployed to test-deployment-pr1311 January 13, 2025 09:57 Destroyed

owi92 force-pushed the series-management branch from 40bae15 to 7a054e4 Compare January 13, 2025 10:31

github-actions bot temporarily deployed to test-deployment-pr1311 January 13, 2025 10:34 Destroyed

github-actions bot temporarily deployed to test-deployment-pr1311 January 13, 2025 13:35 Destroyed

owi92 mentioned this pull request Jan 15, 2025

Add series management pages #1313

Merged

9 tasks

github-actions bot added the status:conflicts This PR has conflicts that need to be resolved label Jan 17, 2025

This comment was marked as outdated.

Sign in to view

owi92 force-pushed the series-management branch from 7768227 to 2582293 Compare January 20, 2025 10:05

github-actions bot removed the status:conflicts This PR has conflicts that need to be resolved label Jan 20, 2025

github-actions bot temporarily deployed to test-deployment-pr1311 January 20, 2025 10:08 Destroyed

github-actions bot added the status:conflicts This PR has conflicts that need to be resolved label Jan 20, 2025

This comment was marked as outdated.

Sign in to view

owi92 force-pushed the series-management branch from 2582293 to 46c24bc Compare January 20, 2025 11:41

github-actions bot removed the status:conflicts This PR has conflicts that need to be resolved label Jan 20, 2025

github-actions bot temporarily deployed to test-deployment-pr1311 January 20, 2025 11:44 Destroyed

github-actions bot added the status:conflicts This PR has conflicts that need to be resolved label Jan 27, 2025

This comment was marked as outdated.

Sign in to view

owi92 force-pushed the series-management branch from 46c24bc to 53908b1 Compare January 27, 2025 16:21

github-actions bot removed the status:conflicts This PR has conflicts that need to be resolved label Jan 27, 2025

github-actions bot temporarily deployed to test-deployment-pr1311 January 27, 2025 16:24 Destroyed

github-actions bot temporarily deployed to test-deployment-pr1311 January 27, 2025 18:10 Destroyed

owi92 force-pushed the series-management branch from b6b8bca to 8d766f6 Compare January 27, 2025 21:31

github-actions bot temporarily deployed to test-deployment-pr1311 January 27, 2025 21:33 Destroyed

owi92 force-pushed the series-management branch from 8d766f6 to 1e32aed Compare January 27, 2025 21:34

github-actions bot added the status:conflicts This PR has conflicts that need to be resolved label Feb 4, 2025

This comment was marked as outdated.

Sign in to view

owi92 added 2 commits February 9, 2025 17:17

Rename Asset to Item

650e78a

I didn't like the name.

Slim down Item type, simplify some code

507dbc9

It did not need to be so complicated.

github-actions bot temporarily deployed to test-deployment-pr1311 February 10, 2025 09:44 Destroyed

LukasKalbertodt requested changes Feb 12, 2025

View reviewed changes

github-actions bot temporarily deployed to test-deployment-pr1311 February 17, 2025 09:47 Destroyed

owi92 force-pushed the series-management branch from 4d08990 to 84861ab Compare February 18, 2025 11:24

github-actions bot temporarily deployed to test-deployment-pr1311 February 18, 2025 11:29 Destroyed

LukasKalbertodt requested changes Feb 20, 2025

View reviewed changes

owi92 added 2 commits February 20, 2025 12:44

Address backend review

6157f5f

Add migration for series index

08eabfb

owi92 force-pushed the series-management branch from 84861ab to bd91318 Compare February 20, 2025 13:54

github-actions bot temporarily deployed to test-deployment-pr1311 February 20, 2025 13:58 Destroyed

Address frontend review

bda0b42

owi92 force-pushed the series-management branch from bd91318 to bda0b42 Compare February 20, 2025 15:13

github-actions bot temporarily deployed to test-deployment-pr1311 February 20, 2025 15:16 Destroyed

LukasKalbertodt and others added 6 commits February 21, 2025 15:08

Avoid some local variables by moving them to format!

3e83abf

Simplify acl filter and parameter passing a bit

58b9cc0

Use separate query for total count in myFoo

a02df5d

Move types related to series thumbnail stack around

cd6b413

Just some refactoring, but which slightly changes the API in an insignificant way.

Merge pull request #3 from LukasKalbertodt/series-management

055ab26

Solve 1+n query problem

github-actions bot temporarily deployed to test-deployment-pr1311 February 24, 2025 12:35 Destroyed

LukasKalbertodt merged commit a0c93b2 into elan-ev:next Feb 24, 2025
4 checks passed

owi92 deleted the series-management branch March 3, 2025 13:42

This was referenced Apr 23, 2025

Add "My series" to manage area #355

Closed

Edit ACLs of series #1366

Closed

Make ACLs of events and series editable #356

Closed

dagraf mentioned this pull request Apr 28, 2025

PROJECT: Tobira: Enable the creation and editing of series opencast/roadmap#19

Open

Add "My series" page #1311

Add "My series" page #1311

Uh oh!

Conversation

owi92 commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

LukasKalbertodt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LukasKalbertodt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LukasKalbertodt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

owi92 commented Jan 9, 2025 •

edited

Loading