Make role idempotent and controllable by variables in addition to --skip-tags #175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
It would be nice if this role would be idempotent (only show changed on an ansible task if it realy changed somtehing on the system).
Furthermore
--skip-tags setup_filesystem
is prone to error because it is not the default behavior when running ansible.This PR tries to fix this while remaining backwards compatible.
It changes the following:
GRUB_CMDLINE_LINUX
are only present once. Even if they are already defined in different orderGRUB_CMDLINE_LINUX
is changed (controllable withece_do_bootloader_reboot
)ece_do_*
variables in addition to the--skip-tags
functionality (the default value of the variables represent the same behavior as it would be used with the--skip-tags
)ece_do_cloudinit
to disable all cloud-init related tasks{{ data_dir }}/docker
toelastic
User and group makes IMHO no sense, since the docker service will change it back toroot
after a restart. So this PR removes it